C# Views - Use Name from ViewAttribute instead of Method Name (#3792)

C# Views - Use Name from ViewAttribute instead of Method Name

# Description of Changes

The [documentation for C#
views](https://spacetimedb.com/docs/modules/c-sharp#views) says that
"Views must be declared as Public, **with an explicit Name**, and
[...]". However, the `Name` provided to the `View` attribute is not
being used as the name of the view in the Module or the generated C#
client SDK code. The `ViewDeclaration` actually checks that the `View`
attribute's name is not null or empty, but then proceeds to do nothing
with it.

This PR updates the `ViewDeclaration` to use the `Name` property from
`ViewAttribute`.

For more info - see my bug report in Discord:
https://discord.com/channels/1037340874172014652/1443881580602069043

# API and ABI breaking changes

No breaking change to the API. Though, anyone who has a view name
declared that's different from their method name will have to deal with
that during migration of their modules.

# Expected complexity level and risk

1 - Trivial change

# Testing

I compiled the C# projects under `crates/bindings-csharp`, built the
NuGet packages, and tested them locally with a project using SpacetimeDB
1.10 (CLI and associated packages).

I confirmed that the generated classes now use the value from the `View`
attribute as the `RemoteTableName`. See attached image.

<img width="1429" height="372" alt="Screenshot 2025-11-28 at 3 04 48 PM"
src="https://github.com/user-attachments/assets/1db83c14-b0dc-4bcb-87ac-50e104f4d501"
/>

---------

Co-authored-by: rekhoff <r.ekhoff@clockworklabs.io>
Co-authored-by: joshua-spacetime <josh@clockworklabs.io>

Author: 3 people

crates/bindings-csharp/Codegen.Tests/fixtures/diag/snapshots/Module#FFI.verified.cs

@@ -1081,13 +1081,13 @@ public sealed class Local
     }
 }
 
-sealed class PublicTableByIdentityViewDispatcher : global::SpacetimeDB.Internal.IView
+sealed class public_table_viewViewDispatcher : global::SpacetimeDB.Internal.IView
 {
     public SpacetimeDB.Internal.RawViewDefV9 MakeViewDef(
         SpacetimeDB.BSATN.ITypeRegistrar registrar
     ) =>
         new global::SpacetimeDB.Internal.RawViewDefV9(
-            Name: "PublicTableByIdentity",
+            Name: "public_table_view",
             Index: 0,
             IsPublic: true,
             IsAnonymous: false,
@@ -1118,19 +1118,20 @@ public byte[] Invoke(
         }
         catch (System.Exception e)
         {
-            global::SpacetimeDB.Log.Error("Error in view 'PublicTableByIdentity': " + e);
+            global::SpacetimeDB.Log.Error("Error in view 'public_table_view': " + e);
             throw;
         }
     }
 }
 
-sealed class FindPublicTableByIdentityViewDispatcher : global::SpacetimeDB.Internal.IAnonymousView
+sealed class find_public_table__by_identityViewDispatcher
+    : global::SpacetimeDB.Internal.IAnonymousView
 {
     public SpacetimeDB.Internal.RawViewDefV9 MakeAnonymousViewDef(
         SpacetimeDB.BSATN.ITypeRegistrar registrar
     ) =>
         new global::SpacetimeDB.Internal.RawViewDefV9(
-            Name: "FindPublicTableByIdentity",
+            Name: "find_public_table__by_identity",
             Index: 0,
             IsPublic: true,
             IsAnonymous: true,
@@ -1163,7 +1164,7 @@ public byte[] Invoke(
         }
         catch (System.Exception e)
         {
-            global::SpacetimeDB.Log.Error("Error in view 'FindPublicTableByIdentity': " + e);
+            global::SpacetimeDB.Log.Error("Error in view 'find_public_table__by_identity': " + e);
             throw;
         }
     }
@@ -1689,8 +1690,8 @@ public static void Main()
         // IMPORTANT: The order in which we register views matters.
         // It must correspond to the order in which we call `GenerateDispatcherClass`.
         // See the comment on `GenerateDispatcherClass` for more explanation.
-        SpacetimeDB.Internal.Module.RegisterView<PublicTableByIdentityViewDispatcher>();
-        SpacetimeDB.Internal.Module.RegisterAnonymousView<FindPublicTableByIdentityViewDispatcher>();
+        SpacetimeDB.Internal.Module.RegisterView<public_table_viewViewDispatcher>();
+        SpacetimeDB.Internal.Module.RegisterAnonymousView<find_public_table__by_identityViewDispatcher>();
 
         SpacetimeDB.Internal.Module.RegisterTable<
             global::BTreeMultiColumn,

crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#FFI.verified.cs

@@ -945,7 +945,7 @@ public ViewDeclaration(GeneratorAttributeSyntaxContext context, DiagReporter dia
             diag.Report(ErrorDescriptor.ViewArgsUnsupported, methodSyntax);
         }
 
-        Name = method.Name;
+        Name = attr.Name ?? method.Name;
         FullName = SymbolToName(method);
         IsPublic = attr.Public;
         IsAnonymous = isAnonymousContext;