CLJS-1537: Circular dependency detection regression

Author: dnolen

src/main/clojure/cljs/analyzer.cljc

@@ -2503,7 +2503,7 @@
    (defn ns-side-effects
      [env {:keys [op] :as ast} opts]
      (if (= :ns op)
-       (let [{:keys [deps uses require-macros use-macros reload reloads]} ast]
+       (let [{:keys [name deps uses require-macros use-macros reload reloads]} ast]
          (when (and *analyze-deps* (seq deps))
            (analyze-deps name deps env (dissoc opts :macros-ns)))
          (when (and *analyze-deps* (seq uses))

src/test/clojure/cljs/build_api_tests.clj

@@ -149,8 +149,12 @@
 (deftest cljs-1537-circular-deps
   (let [out-file (io/file "out/main.js")]
     (.delete out-file)
-    (build (inputs "src/test/cljs")
-      {:main 'circular-deps.a
-       :optimizations :none
-       :verbose true
-       :output-to "out"})))
+    (try
+      (build (inputs "src/test/cljs")
+        {:main 'circular-deps.a
+         :optimizations :none
+         :verbose true
+         :output-to "out"})
+      (is false)
+      (catch Throwable e
+        (is true)))))