CLJS-1132: compile-file analysis pass optimization broken under Closure optimization and :cache-analysis true

Author: dnolen

src/clj/cljs/closure.clj

@@ -1370,8 +1370,7 @@ should contain the source for the given namespace name."
   ([source opts compiler-env]
      (env/with-compiler-env compiler-env
        (let [compiler-stats (:compiler-stats opts)
-             all-opts (assoc (add-implicit-options opts)
-                        :compilation-mode :non-interactive)
+             all-opts (add-implicit-options opts)
              emit-constants (or (and (= (:optimizations opts) :advanced)
                                      (not (false? (:optimize-constants opts))))
                                 (:optimize-constants opts))]

src/clj/cljs/compiler.clj

@@ -1115,8 +1115,7 @@
                   ;; populate compilation environment with analysis information
                   ;; while it would seem this isn't necessary avoiding to do so damages
                   ;; composition of smaller compilation units like expressions (i.e. REPLs)
-                  (when (and (not= (:compilation-mode opts) :non-interactive)
-                             (not (contains? (::ana/namespaces @env/*compiler*) ns)))
+                  (when (not (contains? (::ana/namespaces @env/*compiler*) ns))
                     (with-core-cljs opts (fn [] (ana/analyze-file src-file opts))))
                   ns-info)))
             (catch Exception e