Allow only READONLY_USERNAME and READONLY_PASSWORD to be set for auth (#72)

This is useful for registries that are supposed to be just mirrors of
upstream registries (using REGISTRIES_JSON).

Author: jingyuanliang

src/authentication-method.ts

@@ -6,19 +6,20 @@ import type { AuthenticatorCredentials } from "./user";
 export async function authenticationMethodFromEnv(env: Env) {
   if (env.JWT_REGISTRY_TOKENS_PUBLIC_KEY) {
     return await newRegistryTokens(env.JWT_REGISTRY_TOKENS_PUBLIC_KEY);
-  } else if (env.USERNAME && env.PASSWORD) {
-    const credentials: AuthenticatorCredentials[] = [
-      { username: env.USERNAME, password: env.PASSWORD, capabilities: ["pull", "push"] }
-    ];
+  } else if ((env.USERNAME && env.PASSWORD) || (env.READONLY_USERNAME && env.READONLY_PASSWORD)) {
+    const credentials: AuthenticatorCredentials[] = [];
 
+    if (env.USERNAME && env.PASSWORD) {
+      credentials.push({ username: env.USERNAME, password: env.PASSWORD, capabilities: ["pull", "push"] });
+    }
     if (env.READONLY_USERNAME && env.READONLY_PASSWORD) {
       credentials.push({ username: env.READONLY_USERNAME, password: env.READONLY_PASSWORD, capabilities: ["pull"] });
     }
 
     return new UserAuthenticator(credentials);
   }
 
-  console.error("Either env.JWT_REGISTRY_TOKENS_PUBLIC_KEY must be set or both env.USERNAME, env.PASSWORD must be set.");
+  console.error("Either env.JWT_REGISTRY_TOKENS_PUBLIC_KEY must be set or both env.USERNAME, env.PASSWORD must be set or both env.READONLY_USERNAME, env.READONLY_PASSWORD must be set.");
 
   // invalid configuration
   return undefined;

test/index.test.ts

@@ -466,6 +466,30 @@ describe("http client", () => {
 
     expect("exists" in res && res.exists).toBe(false);
   });
+
+  test("test manifest exists with readonly", async () => {
+    envBindings = { ...bindings };
+    envBindings.JWT_REGISTRY_TOKENS_PUBLIC_KEY = "";
+    envBindings.PASSWORD = "";
+    envBindings.USERNAME = "";
+    envBindings.READONLY_PASSWORD = "world";
+    envBindings.READONLY_USERNAME = "hello";
+    envBindings.REGISTRIES_JSON = undefined;
+    global.fetch = async function (r: RequestInfo): Promise<Response> {
+      return fetch(new Request(r));
+    };
+    const client = new RegistryHTTPClient(envBindings, {
+      registry: "https://localhost",
+      password_env: "PASSWORD",
+      username: "hello",
+    });
+    const res = await client.manifestExists("namespace/hello", "latest");
+    if ("response" in res) {
+      expect(await res.response.json()).toEqual({ status: res.response.status });
+    }
+
+    expect("exists" in res && res.exists).toBe(false);
+  });
 });
 
 describe("push and catalog", () => {