Merge pull request #241 from cloudflare/nightly

Nightly -> Main release

Author: AshishKumar4

.github/workflows/claude-issue-triage.yml

@@ -165,7 +165,7 @@ jobs:
             
             ### STAGE 3: Solution Proposal (CONDITIONAL)${{ steps.analyze.outputs.severity == 'high' && '\n\n**⚠️ REQUIRED** - Critical issue, must propose fix' || '\n\n**OPTIONAL** - Propose fix if solution is clear and straightforward' }}
             
-            ${{ steps.analyze.outputs.severity == 'high' && '**You MUST propose a fix for this critical issue:**' || '**Propose a fix only if:**\n- Root cause is clear\n- Fix is straightforward (< 50 lines changed)\n- You\'re confident it won\'t introduce regressions' }}
+            ${{ steps.analyze.outputs.severity == 'high' && '**You MUST propose a fix for this critical issue:**' || '**Propose a fix only if:**\n- Root cause is clear\n- Fix is straightforward (< 50 lines changed)\n- You''re confident it won''t introduce regressions' }}
             
             #### 3.1 Design the Fix
             
@@ -249,7 +249,7 @@ jobs:
             
             **Comment Structure** (adapt based on investigation depth):
             
-            ${{ steps.analyze.outputs.should_investigate == 'true' && '**For investigated issues:**\n\n```markdown\n## Investigation Results\n\nThanks for reporting this, @${{ github.event.issue.user.login }}! I\'ve performed a thorough analysis.\n\n### Classification\n- **Type:** [bug/feature/etc]\n- **Severity:** [P0-critical/P1-high/etc]\n- **Component:** [worker/ui/etc]\n\n### Root Cause Analysis\n[Detailed explanation of what\'s causing the issue]\n\n**Location:** `path/to/file.ts:123`\n\n**Introduced in:** PR #XXX (if found) or Commit ABC123\n\n### Proposed Solution\n[Explain the fix approach]\n\n### Status\n- ✅ PR #XXX created with proposed fix (if applicable)\n- ⏳ Requires manual review and testing\n- 📋 Added to backlog for team review (if no PR)\n\n### Next Steps\n[What happens next - PR review, team discussion, etc.]\n```' || '**For standard triage:**\n\n```markdown\nThanks for reporting this, @${{ github.event.issue.user.login }}!\n\n### Classification\n- **Labels:** [list applied labels]\n- **Priority:** [explanation of priority]\n\n[Context-specific response based on issue type]\n\n### Next Steps\nThe team will review this and provide updates.\n```' }}
+            ${{ steps.analyze.outputs.should_investigate == 'true' && '**For investigated issues:**\n\n```markdown\n## Investigation Results\n\nThanks for reporting this, @${{ github.event.issue.user.login }}! I''ve performed a thorough analysis.\n\n### Classification\n- **Type:** [bug/feature/etc]\n- **Severity:** [P0-critical/P1-high/etc]\n- **Component:** [worker/ui/etc]\n\n### Root Cause Analysis\n[Detailed explanation of what''s causing the issue]\n\n**Location:** `path/to/file.ts:123`\n\n**Introduced in:** PR #XXX (if found) or Commit ABC123\n\n### Proposed Solution\n[Explain the fix approach]\n\n### Status\n- ✅ PR #XXX created with proposed fix (if applicable)\n- ⏳ Requires manual review and testing\n- 📋 Added to backlog for team review (if no PR)\n\n### Next Steps\n[What happens next - PR review, team discussion, etc.]\n```' || '**For standard triage:**\n\n```markdown\nThanks for reporting this, @${{ github.event.issue.user.login }}!\n\n### Classification\n- **Labels:** [list applied labels]\n- **Priority:** [explanation of priority]\n\n[Context-specific response based on issue type]\n\n### Next Steps\nThe team will review this and provide updates.\n```' }}
             
             ---
             

.github/workflows/claude-reviews.yml

@@ -45,32 +45,6 @@ jobs:
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Minimize Old Review Comments
-        run: |
-          echo "Collapsing previous review comments from github-actions[bot]..."
-          
-          # Get all comments from github-actions[bot] on this PR
-          OLD_REVIEWS=$(gh api repos/${{ github.repository }}/issues/${{ github.event.pull_request.number }}/comments \
-            --jq '[.[] | select(.user.login == "github-actions[bot]") | select(.body | contains("## Code Review") or contains("🔒 **CRITICAL PATH SECURITY REVIEW**") or contains("## 🔍 Code Quality & Security Review")) | .id]')
-          
-          if [ -n "$OLD_REVIEWS" ] && [ "$OLD_REVIEWS" != "[]" ]; then
-            echo "Found old review comments to collapse"
-            echo "$OLD_REVIEWS" | jq -r '.[]' | while read comment_id; do
-              echo "Collapsing comment $comment_id"
-              gh api repos/${{ github.repository }}/issues/comments/$comment_id -X PATCH \
-                -f body="<details><summary>🔒 Previous review (outdated)</summary>
-
-          This review has been superseded by a newer review.
-          </details>" || echo "Failed to collapse comment $comment_id"
-            done
-            echo "✓ Old comments collapsed"
-          else
-            echo "No old review comments found"
-          fi
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        continue-on-error: true
-
       - name: Run Comprehensive Review
         uses: anthropics/claude-code-action@v1
         with:
@@ -137,16 +111,8 @@ jobs:
                [Overall assessment with approval/disapproval reasoning]
                ```
             
-            5. Post review (MANDATORY FINAL STEP - use single efficient command)
+            5. Post review (MANDATORY FINAL STEP)
                ```bash
-               # Post new review (collapse old ones first if any exist)
-               OLD_IDS=$(gh api repos/${{ github.repository }}/issues/${{ github.event.pull_request.number }}/comments --jq '[.[] | select(.user.login == "github-actions[bot]") | select(.body | startswith("## Code & Security Review")) | .id] | @csv' | tr -d '"')
-               if [ -n "$OLD_IDS" ]; then
-                 for id in ${OLD_IDS//,/ }; do
-                   gh api -X PATCH repos/${{ github.repository }}/issues/comments/$id -f body="<details><summary>Outdated</summary></details>" &
-                 done
-                 wait
-               fi
                gh pr comment ${{ github.event.pull_request.number }} --repo ${{ github.repository }} --body "YOUR_REVIEW_HERE"
                ```
             
@@ -180,3 +146,42 @@ jobs:
             --allowed-tools "mcp__github_inline_comment__create_inline_comment,Bash(gh issue view:*),Bash(gh issue list:*),Bash(gh search:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr edit:*),Bash(gh api:*)"
             --max-turns ${{ steps.critical_paths.outputs.is_critical == 'true' && '90' || '65' }}
             --model claude-sonnet-4-5-20250929
+      
+      - name: Intelligent Comment Cleanup
+        uses: anthropics/claude-code-action@v1
+        if: always()
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
+          prompt: |
+            Clean up stale bot comments on PR #${{ github.event.pull_request.number }}.
+            
+            **Task:**
+            1. Fetch all comments on this PR
+            2. Identify bot comments (users ending in [bot]) that are stale/outdated:
+               - Old reviews superseded by newer ones
+               - Old PR description suggestions
+               - Previously collapsed/outdated markers
+               - Progress/status comments from previous workflow runs
+            3. Keep only the most recent comment per category per bot
+            4. DELETE all stale comments (do not collapse)
+            
+            **Get all comments:**
+            ```bash
+            gh api repos/${{ github.repository }}/issues/${{ github.event.pull_request.number }}/comments --jq '.[] | {id, user: .user.login, body, created_at}'
+            ```
+            
+            **Delete a comment:**
+            ```bash
+            gh api repos/${{ github.repository }}/issues/comments/COMMENT_ID -X DELETE
+            ```
+            
+            Be intelligent:
+            - Preserve the newest useful comment in each category
+            - Delete everything else that's redundant or stale
+            - If unsure, keep the comment (conservative approach)
+          
+          claude_args: |
+            --allowed-tools "Bash(gh api repos/*/issues/*/comments:*),Bash(gh api repos/*/issues/comments/*:*)"
+            --max-turns 8
+            --model claude-haiku-4-5-20251001

src/components/monaco-editor/monaco-editor.tsx

@@ -36,7 +36,7 @@ self.MonacoEnvironment = {
 };
 
 // From GitHub Dark theme
-monaco.editor.defineTheme('v1-dev-dark', {
+monaco.editor.defineTheme('vibesdk-dark', {
 	base: 'vs-dark',
 	inherit: true,
 	rules: [
@@ -77,7 +77,7 @@ monaco.editor.defineTheme('v1-dev-dark', {
 	},
 });
 
-monaco.editor.defineTheme('v1-dev', {
+monaco.editor.defineTheme('vibesdk', {
 	base: 'vs',
 	inherit: true,
 	rules: [
@@ -116,43 +116,13 @@ monaco.editor.defineTheme('v1-dev', {
 	},
 });
 
-monaco.editor.setTheme('v1-dev');
-
-monaco.languages.typescript.typescriptDefaults.setDiagnosticsOptions({
-	noSemanticValidation: true,
-	noSyntaxValidation: true,
-});
-
-// Configure TypeScript defaults for JSX support
-monaco.languages.typescript.typescriptDefaults.setCompilerOptions({
-	jsx: monaco.languages.typescript.JsxEmit.React,
-	allowJs: true,
-	allowSyntheticDefaultImports: true,
-	esModuleInterop: true,
-	moduleResolution: monaco.languages.typescript.ModuleResolutionKind.NodeJs,
-	module: monaco.languages.typescript.ModuleKind.ESNext,
-	target: monaco.languages.typescript.ScriptTarget.ESNext,
-	jsxFactory: 'React.createElement',
-	jsxFragmentFactory: 'React.Fragment',
-});
-
-// Configure JavaScript defaults for JSX support
-monaco.languages.typescript.javascriptDefaults.setCompilerOptions({
-	allowJs: true,
-	allowSyntheticDefaultImports: true,
-	esModuleInterop: true,
-	jsx: monaco.languages.typescript.JsxEmit.React,
-	moduleResolution: monaco.languages.typescript.ModuleResolutionKind.NodeJs,
-	module: monaco.languages.typescript.ModuleKind.ESNext,
-	target: monaco.languages.typescript.ScriptTarget.ESNext,
-	jsxFactory: 'React.createElement',
-	jsxFragmentFactory: 'React.Fragment',
-});
+monaco.editor.setTheme('vibesdk');
 
 export type MonacoEditorProps = React.ComponentProps<'div'> & {
 	createOptions?: monaco.editor.IStandaloneEditorConstructionOptions;
 	find?: string;
 	replace?: string;
+	enableTypeScriptFeatures?: 'auto' | boolean;
 };
 
 /**
@@ -163,6 +133,7 @@ export const MonacoEditor = memo<MonacoEditorProps>(function MonacoEditor({
 	createOptions = {},
 	find,
 	replace,
+	enableTypeScriptFeatures = 'auto',
 	...props
 }) {
 	const containerRef = useRef<HTMLDivElement>(null);
@@ -171,6 +142,63 @@ export const MonacoEditor = memo<MonacoEditorProps>(function MonacoEditor({
 	const stickyScroll = useRef(true);
 	const { theme } = useTheme();
 
+	const shouldEnableTypeScript = React.useMemo(() => {
+		if (enableTypeScriptFeatures === 'auto') {
+			return !createOptions.readOnly;
+		}
+		return enableTypeScriptFeatures;
+	}, [enableTypeScriptFeatures, createOptions.readOnly]);
+
+	// Configure TypeScript diagnostics based on mode
+	useEffect(() => {
+		const tsDefaults = monaco.languages.typescript.typescriptDefaults;
+		const jsDefaults = monaco.languages.typescript.javascriptDefaults;
+
+		if (shouldEnableTypeScript) {
+			// Enable full IntelliSense for editing
+			tsDefaults.setDiagnosticsOptions({
+				noSemanticValidation: false,
+				noSyntaxValidation: false,
+			});
+			tsDefaults.setCompilerOptions({
+				jsx: monaco.languages.typescript.JsxEmit.React,
+				allowJs: true,
+				allowSyntheticDefaultImports: true,
+				esModuleInterop: true,
+				moduleResolution: monaco.languages.typescript.ModuleResolutionKind.NodeJs,
+				module: monaco.languages.typescript.ModuleKind.ESNext,
+				target: monaco.languages.typescript.ScriptTarget.ESNext,
+				jsxFactory: 'React.createElement',
+				jsxFragmentFactory: 'React.Fragment',
+			});
+			jsDefaults.setCompilerOptions({
+				allowJs: true,
+				allowSyntheticDefaultImports: true,
+				esModuleInterop: true,
+				jsx: monaco.languages.typescript.JsxEmit.React,
+				moduleResolution: monaco.languages.typescript.ModuleResolutionKind.NodeJs,
+				module: monaco.languages.typescript.ModuleKind.ESNext,
+				target: monaco.languages.typescript.ScriptTarget.ESNext,
+				jsxFactory: 'React.createElement',
+				jsxFragmentFactory: 'React.Fragment',
+			});
+		} else {
+			// Disable expensive features for viewing
+			tsDefaults.setDiagnosticsOptions({
+				noSemanticValidation: true,
+				noSyntaxValidation: true,
+			});
+			tsDefaults.setCompilerOptions({
+				jsx: monaco.languages.typescript.JsxEmit.React,
+				target: monaco.languages.typescript.ScriptTarget.ESNext,
+			});
+			jsDefaults.setCompilerOptions({
+				jsx: monaco.languages.typescript.JsxEmit.React,
+				target: monaco.languages.typescript.ScriptTarget.ESNext,
+			});
+		}
+	}, [shouldEnableTypeScript]);
+
 
 	useEffect(() => {
 		let configuredTheme = theme;
@@ -180,7 +208,7 @@ export const MonacoEditor = memo<MonacoEditorProps>(function MonacoEditor({
 		editor.current = monaco.editor.create(containerRef.current!, {
 			language: createOptions.language || 'typescript',
 			minimap: { enabled: false },
-			theme: configuredTheme === 'dark' ? 'v1-dev-dark' : 'v1-dev',
+			theme: configuredTheme === 'dark' ? 'vibesdk-dark' : 'vibesdk',
 			automaticLayout: true,
 			value: defaultCode,
 			fontSize: 13,
@@ -207,6 +235,10 @@ export const MonacoEditor = memo<MonacoEditorProps>(function MonacoEditor({
 		}
 
 		return () => {
+			const model = editor.current?.getModel();
+			if (model) {
+				model.dispose();
+			}
 			editor.current?.dispose();
 		};
 		// eslint-disable-next-line react-hooks/exhaustive-deps
@@ -217,10 +249,16 @@ export const MonacoEditor = memo<MonacoEditorProps>(function MonacoEditor({
 			const model = editor.current.getModel();
 			if (!model) return;
 
-			editor.current.setValue(createOptions.value || '');
+			model.pushEditOperations(
+				[],
+				[{
+					range: model.getFullModelRange(),
+					text: createOptions.value || ''
+				}],
+				() => null
+			);
 
 			if (stickyScroll.current) {
-				// Scroll to bottom
 				const lineCount = model.getLineCount();
 				editor.current.revealLine(lineCount);
 			}
@@ -293,7 +331,7 @@ export const MonacoEditor = memo<MonacoEditorProps>(function MonacoEditor({
 	// Update theme when app theme changes
 	useEffect(() => {
 		if (editor.current) {
-			monaco.editor.setTheme(theme === 'dark' ? 'v1-dev-dark' : 'v1-dev');
+			monaco.editor.setTheme(theme === 'dark' ? 'vibesdk-dark' : 'vibesdk');
 		}
 	}, [theme]);
 

src/routes/app/index.tsx

@@ -1000,7 +1000,7 @@ export default function AppView() {
 																		'on',
 																	scrollBeyondLastLine: false,
 																	fontSize: 13,
-																	theme: 'v1-dev',
+																	theme: 'vibesdk',
 																	automaticLayout: true,
 																}}
 															/>

src/routes/chat/chat.tsx

@@ -413,28 +413,7 @@ export default function Chat() {
 			setView('editor');
 		}
 	}, [isGeneratingBlueprint, view]);
-
-	useEffect(() => {
-		// Only show bootstrap completion message for NEW chats, not when reloading existing ones
-		if (doneStreaming && !isGeneratingBlueprint && !blueprint && urlChatId === 'new') {
-			onCompleteBootstrap();
-			sendAiMessage(
-				createAIMessage(
-					'creating-blueprint',
-					'Bootstrapping complete, now creating a blueprint for you...',
-					true,
-				),
-			);
-		}
-	}, [
-		doneStreaming,
-		isGeneratingBlueprint,
-		sendAiMessage,
-		blueprint,
-		onCompleteBootstrap,
-		urlChatId,
-	]);
-
+    
 	const isRunning = useMemo(() => {
 		return (
 			isBootstrapping || isGeneratingBlueprint // || codeGenState === 'active'
@@ -1183,7 +1162,7 @@ export default function Chat() {
 														lineNumbers: 'on',
 														scrollBeyondLastLine: false,
 														fontSize: 13,
-														theme: 'v1-dev',
+														theme: 'vibesdk',
 														automaticLayout: true,
 													}}
 													find={

src/routes/chat/hooks/use-chat.ts

@@ -294,6 +294,7 @@ export function useChat({
 					// Request file generation for new chats only
 					if (!disableGenerate && urlChatId === 'new') {
 						logger.debug('🔄 Starting code generation for new chat');
+						setIsGenerating(true);
 						sendWebSocketMessage(ws, 'generate_all');
 					}
 				});