Merge pull request #244 from cloudflare/nightly

Release: Nightly -> Main

Author: AshishKumar4

.github/workflows/claude-issue-triage.yml

@@ -165,7 +165,7 @@ jobs:
             
             ### STAGE 3: Solution Proposal (CONDITIONAL)${{ steps.analyze.outputs.severity == 'high' && '\n\n**⚠️ REQUIRED** - Critical issue, must propose fix' || '\n\n**OPTIONAL** - Propose fix if solution is clear and straightforward' }}
             
-            ${{ steps.analyze.outputs.severity == 'high' && '**You MUST propose a fix for this critical issue:**' || '**Propose a fix only if:**\n- Root cause is clear\n- Fix is straightforward (< 50 lines changed)\n- You\'re confident it won\'t introduce regressions' }}
+            ${{ steps.analyze.outputs.severity == 'high' && '**You MUST propose a fix for this critical issue:**' || '**Propose a fix only if:**\n- Root cause is clear\n- Fix is straightforward (< 50 lines changed)\n- You''re confident it won''t introduce regressions' }}
             
             #### 3.1 Design the Fix
             
@@ -249,7 +249,7 @@ jobs:
             
             **Comment Structure** (adapt based on investigation depth):
             
-            ${{ steps.analyze.outputs.should_investigate == 'true' && '**For investigated issues:**\n\n```markdown\n## Investigation Results\n\nThanks for reporting this, @${{ github.event.issue.user.login }}! I\'ve performed a thorough analysis.\n\n### Classification\n- **Type:** [bug/feature/etc]\n- **Severity:** [P0-critical/P1-high/etc]\n- **Component:** [worker/ui/etc]\n\n### Root Cause Analysis\n[Detailed explanation of what\'s causing the issue]\n\n**Location:** `path/to/file.ts:123`\n\n**Introduced in:** PR #XXX (if found) or Commit ABC123\n\n### Proposed Solution\n[Explain the fix approach]\n\n### Status\n- ✅ PR #XXX created with proposed fix (if applicable)\n- ⏳ Requires manual review and testing\n- 📋 Added to backlog for team review (if no PR)\n\n### Next Steps\n[What happens next - PR review, team discussion, etc.]\n```' || '**For standard triage:**\n\n```markdown\nThanks for reporting this, @${{ github.event.issue.user.login }}!\n\n### Classification\n- **Labels:** [list applied labels]\n- **Priority:** [explanation of priority]\n\n[Context-specific response based on issue type]\n\n### Next Steps\nThe team will review this and provide updates.\n```' }}
+            ${{ steps.analyze.outputs.should_investigate == 'true' && '**For investigated issues:**\n\n```markdown\n## Investigation Results\n\nThanks for reporting this, @${{ github.event.issue.user.login }}! I''ve performed a thorough analysis.\n\n### Classification\n- **Type:** [bug/feature/etc]\n- **Severity:** [P0-critical/P1-high/etc]\n- **Component:** [worker/ui/etc]\n\n### Root Cause Analysis\n[Detailed explanation of what''s causing the issue]\n\n**Location:** `path/to/file.ts:123`\n\n**Introduced in:** PR #XXX (if found) or Commit ABC123\n\n### Proposed Solution\n[Explain the fix approach]\n\n### Status\n- ✅ PR #XXX created with proposed fix (if applicable)\n- ⏳ Requires manual review and testing\n- 📋 Added to backlog for team review (if no PR)\n\n### Next Steps\n[What happens next - PR review, team discussion, etc.]\n```' || '**For standard triage:**\n\n```markdown\nThanks for reporting this, @${{ github.event.issue.user.login }}!\n\n### Classification\n- **Labels:** [list applied labels]\n- **Priority:** [explanation of priority]\n\n[Context-specific response based on issue type]\n\n### Next Steps\nThe team will review this and provide updates.\n```' }}
             
             ---
             

.github/workflows/claude-reviews.yml

@@ -45,32 +45,6 @@ jobs:
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Minimize Old Review Comments
-        run: |
-          echo "Collapsing previous review comments from github-actions[bot]..."
-          
-          # Get all comments from github-actions[bot] on this PR
-          OLD_REVIEWS=$(gh api repos/${{ github.repository }}/issues/${{ github.event.pull_request.number }}/comments \
-            --jq '[.[] | select(.user.login == "github-actions[bot]") | select(.body | contains("## Code Review") or contains("🔒 **CRITICAL PATH SECURITY REVIEW**") or contains("## 🔍 Code Quality & Security Review")) | .id]')
-          
-          if [ -n "$OLD_REVIEWS" ] && [ "$OLD_REVIEWS" != "[]" ]; then
-            echo "Found old review comments to collapse"
-            echo "$OLD_REVIEWS" | jq -r '.[]' | while read comment_id; do
-              echo "Collapsing comment $comment_id"
-              gh api repos/${{ github.repository }}/issues/comments/$comment_id -X PATCH \
-                -f body="<details><summary>🔒 Previous review (outdated)</summary>
-
-          This review has been superseded by a newer review.
-          </details>" || echo "Failed to collapse comment $comment_id"
-            done
-            echo "✓ Old comments collapsed"
-          else
-            echo "No old review comments found"
-          fi
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        continue-on-error: true
-
       - name: Run Comprehensive Review
         uses: anthropics/claude-code-action@v1
         with:
@@ -137,16 +111,8 @@ jobs:
                [Overall assessment with approval/disapproval reasoning]
                ```
             
-            5. Post review (MANDATORY FINAL STEP - use single efficient command)
+            5. Post review (MANDATORY FINAL STEP)
                ```bash
-               # Post new review (collapse old ones first if any exist)
-               OLD_IDS=$(gh api repos/${{ github.repository }}/issues/${{ github.event.pull_request.number }}/comments --jq '[.[] | select(.user.login == "github-actions[bot]") | select(.body | startswith("## Code & Security Review")) | .id] | @csv' | tr -d '"')
-               if [ -n "$OLD_IDS" ]; then
-                 for id in ${OLD_IDS//,/ }; do
-                   gh api -X PATCH repos/${{ github.repository }}/issues/comments/$id -f body="<details><summary>Outdated</summary></details>" &
-                 done
-                 wait
-               fi
                gh pr comment ${{ github.event.pull_request.number }} --repo ${{ github.repository }} --body "YOUR_REVIEW_HERE"
                ```
             
@@ -180,3 +146,42 @@ jobs:
             --allowed-tools "mcp__github_inline_comment__create_inline_comment,Bash(gh issue view:*),Bash(gh issue list:*),Bash(gh search:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr edit:*),Bash(gh api:*)"
             --max-turns ${{ steps.critical_paths.outputs.is_critical == 'true' && '90' || '65' }}
             --model claude-sonnet-4-5-20250929
+      
+      - name: Intelligent Comment Cleanup
+        uses: anthropics/claude-code-action@v1
+        if: always()
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
+          prompt: |
+            Clean up stale bot comments on PR #${{ github.event.pull_request.number }}.
+            
+            **Task:**
+            1. Fetch all comments on this PR
+            2. Identify bot comments (users ending in [bot]) that are stale/outdated:
+               - Old reviews superseded by newer ones
+               - Old PR description suggestions
+               - Previously collapsed/outdated markers
+               - Progress/status comments from previous workflow runs
+            3. Keep only the most recent comment per category per bot
+            4. DELETE all stale comments (do not collapse)
+            
+            **Get all comments:**
+            ```bash
+            gh api repos/${{ github.repository }}/issues/${{ github.event.pull_request.number }}/comments --jq '.[] | {id, user: .user.login, body, created_at}'
+            ```
+            
+            **Delete a comment:**
+            ```bash
+            gh api repos/${{ github.repository }}/issues/comments/COMMENT_ID -X DELETE
+            ```
+            
+            Be intelligent:
+            - Preserve the newest useful comment in each category
+            - Delete everything else that's redundant or stale
+            - If unsure, keep the comment (conservative approach)
+          
+          claude_args: |
+            --allowed-tools "Bash(gh api repos/*/issues/*/comments:*),Bash(gh api repos/*/issues/comments/*:*)"
+            --max-turns 8
+            --model claude-haiku-4-5-20251001

.husky/commit-msg

@@ -1 +1,10 @@
-bunx commitlint --edit $1
+# Add common bun installation paths to PATH
+export PATH="/opt/homebrew/bin:$HOME/.bun/bin:$PATH"
+
+# Run commitlint if bunx is available
+if command -v bunx >/dev/null 2>&1; then
+  bunx commitlint --edit $1
+else
+  echo "⚠️  bunx not found in PATH, skipping commitlint"
+  exit 0
+fi

.husky/pre-commit

@@ -1 +1,10 @@
-bun test
+# Add common bun installation paths to PATH
+export PATH="/opt/homebrew/bin:$HOME/.bun/bin:$PATH"
+
+# Run tests with bun
+if command -v bun >/dev/null 2>&1; then
+  bun test
+else
+  echo "⚠️  bun not found in PATH, skipping tests"
+  exit 0
+fi

SandboxDockerfile

@@ -1,5 +1,5 @@
 # FROM docker.io/cloudflare/sandbox:0.1.3
-FROM docker.io/cloudflare/sandbox:0.4.14
+FROM docker.io/cloudflare/sandbox:0.5.6
 
 ARG TARGETARCH
 RUN apt-get update && \
@@ -52,7 +52,6 @@ RUN chmod 755 /workspace/data
 # Set environment variable to indicate Docker container environment
 ENV CONTAINER_ENV=docker
 ENV VITE_LOGGER_TYPE=json 
-
 # # Set environment variable to indicate Docker container environment
 # ENV CONTAINER_ENV=docker
 

bun.lock

@@ -6,7 +6,7 @@
       "dependencies": {
         "@ashishkumar472/cf-git": "1.0.5",
         "@cloudflare/containers": "^0.0.28",
-        "@cloudflare/sandbox": "0.4.14",
+        "@cloudflare/sandbox": "^0.5.6",
         "@noble/ciphers": "^1.3.0",
         "@octokit/rest": "^22.0.1",
         "@radix-ui/react-accordion": "^1.2.12",
@@ -230,7 +230,7 @@
 
     "@cloudflare/kv-asset-handler": ["@cloudflare/kv-asset-handler@0.4.0", "", { "dependencies": { "mime": "^3.0.0" } }, "sha512-+tv3z+SPp+gqTIcImN9o0hqE9xyfQjI1XD9pL6NuKjua9B1y7mNYv0S9cP+QEbA4ppVgGZEmKOvHX5G5Ei1CVA=="],
 
-    "@cloudflare/sandbox": ["@cloudflare/sandbox@0.4.14", "", { "dependencies": { "@cloudflare/containers": "^0.0.30" } }, "sha512-sI8yEqUd/vukhwSHGi93xau7xEtbP+OD/8xnjGbXr2iIGnAV+05VhLVIfJmwuU3VE8R96dnBJtEucEE5ZtXhcQ=="],
+    "@cloudflare/sandbox": ["@cloudflare/sandbox@0.5.6", "", { "dependencies": { "@cloudflare/containers": "^0.0.30" }, "peerDependencies": { "@openai/agents": "^0.3.3" }, "optionalPeers": ["@openai/agents"] }, "sha512-N4mdUY5lVWQHQcAZnTecJne95uSyf7KVPbJGMr3G6jS7oyphriw6Hxa5I/HlDUdMWjaTBgeOuDEb4m3wo2IyOg=="],
 
     "@cloudflare/unenv-preset": ["@cloudflare/unenv-preset@2.7.8", "", { "peerDependencies": { "unenv": "2.0.0-rc.21", "workerd": "^1.20250927.0" }, "optionalPeers": ["workerd"] }, "sha512-Ky929MfHh+qPhwCapYrRPwPVHtA2Ioex/DbGZyskGyNRDe9Ru3WThYZivyNVaPy5ergQSgMs9OKrM9Ajtz9F6w=="],