Merge pull request #491 from cloudinary/fix/fromJson-q-auto-best

Author: strausr

__TESTS__/unit/fromJson/delivery.fromJson.test.ts

@@ -79,6 +79,17 @@ describe('delivery.fromJson', () => {
     expect(transformation.toString()).toStrictEqual('q_auto');
   });
 
+  it('quality:auto:best', () => {
+    const transformation = fromJson([
+      {
+        actionType: 'quality',
+        level: 'autoBest'
+      }
+    ]);
+
+    expect(transformation.toString()).toStrictEqual('q_auto:best');
+  });
+
   it('chromaSubSampling', () => {
     const transformation = fromJson([
       {

src/actions/delivery/DeliveryQualityAction.ts

@@ -2,7 +2,11 @@ import {QualifierValue} from "../../internal/qualifier/QualifierValue.js";
 import {Qualifier} from "../../internal/qualifier/Qualifier.js";
 import {DeliveryAction} from "./DeliveryAction.js";
 import {IDeliveryQualityModel} from "../../internal/models/IDeliveryActionModel.js";
-import {CHROMA_VALUE_TO_CHROMA_MODEL_ENUM, CHROMA_MODEL_ENUM_TO_CHROMA_VALUE} from "../../internal/internalConstants.js";
+import {
+  CHROMA_VALUE_TO_CHROMA_MODEL_ENUM,
+  CHROMA_MODEL_ENUM_TO_CHROMA_VALUE,
+  ACTION_TYPE_TO_QUALITY_MODE_MAP
+} from "../../internal/internalConstants.js";
 import {IActionModel} from "../../internal/models/IActionModel.js";
 
 
@@ -49,7 +53,8 @@ class DeliveryQualityAction extends DeliveryAction {
 
   static fromJson(actionModel: IActionModel): DeliveryQualityAction {
     const {level, chromaSubSampling, quantization} = (actionModel as IDeliveryQualityModel);
-    const result = new this(level);
+    const levelType = ACTION_TYPE_TO_QUALITY_MODE_MAP[level] || level;
+    const result = new this(levelType);
 
     if (chromaSubSampling){
       //Turn strings like 'CHROMA_420' to 420

src/internal/internalConstants.ts

@@ -108,6 +108,10 @@ export const ACTION_TYPE_TO_EFFECT_MODE_MAP: Record<string, string> = {
   unsharpMask: 'unsharp_mask'
 };
 
+export const ACTION_TYPE_TO_QUALITY_MODE_MAP: Record<string, string> = {
+  autoBest: 'auto:best',
+};
+
 export const CHROMA_VALUE_TO_CHROMA_MODEL_ENUM: Record<number, string> = {
   444: "CHROMA_444",
   420: "CHROMA_420"
@@ -129,3 +133,5 @@ export const CROP_MODE_TO_ACTION_TYPE_MAP = objectFlip(ACTION_TYPE_TO_CROP_MODE_
 export const DELIVERY_MODE_TO_ACTION_TYPE_MAP = objectFlip(ACTION_TYPE_TO_DELIVERY_MODE_MAP);
 
 export const EFFECT_MODE_TO_ACTION_TYPE_MAP = objectFlip(ACTION_TYPE_TO_EFFECT_MODE_MAP);
+
+export const QUALITY_MODE_TO_ACTION_TYPE_MAP = objectFlip(ACTION_TYPE_TO_QUALITY_MODE_MAP);