Skip to content

Commit 5a2e1a5

Browse files
Set secure as a default for url configuration (#204)
* Set secure as a default for url configuration
1 parent c27dcab commit 5a2e1a5

23 files changed

+189
-156
lines changed

__TESTS__/unit/Action/Action.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe('Tests for Transformation Action', () => {
2121
.setPublicID('sample')
2222
.toURL();
2323

24-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/a_90/sample');
24+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/a_90/sample');
2525
});
2626
it('Creates a cloudinaryURL with new action while passing an array to addQualifier()', () => {
2727
const action = new Action().addQualifier(new Qualifier('a', new QualifierValue([90, 80]).setDelimiter('.')));
@@ -32,7 +32,7 @@ describe('Tests for Transformation Action', () => {
3232
.setPublicID('sample')
3333
.toURL();
3434

35-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/a_90.80/sample');
35+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/a_90.80/sample');
3636
});
3737
it('Creates a cloudinaryURL with new action using addValue()', () => {
3838
const action = new Action().addQualifier(new Qualifier('a', new QualifierValue([90, 80]).setDelimiter('.')).addValue(70));
@@ -43,7 +43,7 @@ describe('Tests for Transformation Action', () => {
4343
.setPublicID('sample')
4444
.toURL();
4545

46-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/a_90.80.70/sample');
46+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/a_90.80.70/sample');
4747
});
4848
it('Creates a cloudinaryURL with new action while calling addQualifier twice', () => {
4949
const action = new Action()
@@ -56,7 +56,7 @@ describe('Tests for Transformation Action', () => {
5656
.setPublicID('sample')
5757
.toURL();
5858

59-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/c_fill,w_100/sample');
59+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/c_fill,w_100/sample');
6060
});
6161
it('Creates a cloudinaryURL with new action, overwriting existing qualifier', () => {
6262
const action = new Action()
@@ -69,7 +69,7 @@ describe('Tests for Transformation Action', () => {
6969
.setPublicID('sample')
7070
.toURL();
7171

72-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/w_200/sample');
72+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/w_200/sample');
7373
});
7474

7575
it('Creates a cloudinaryURL with new action while adding a single flag', () => {
@@ -83,7 +83,7 @@ describe('Tests for Transformation Action', () => {
8383
.setPublicID('sample')
8484
.toURL();
8585

86-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/fl_layer_apply,l_sample/sample');
86+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/fl_layer_apply,l_sample/sample');
8787
});
8888

8989
it('Creates a cloudinaryURL with new action while adding multiple flags', () => {
@@ -98,7 +98,7 @@ describe('Tests for Transformation Action', () => {
9898
.setPublicID('sample')
9999
.toURL();
100100

101-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/fl_first_flag.second_flag,l_sample/sample');
101+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/fl_first_flag.second_flag,l_sample/sample');
102102
});
103103

104104
it('Correctly sorts qualifiers', () => {

__TESTS__/unit/Instance/Cloudinary.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ describe('Tests for Cloudinary instance', () => {
1515

1616
tImage.resize(fill(10, 10));
1717

18-
expect(tImage.toURL()).toBe('http://res.cloudinary.com/demoInInstance/image/upload/c_fill,h_10,w_10/sample');
18+
expect(tImage.toURL()).toBe('https://res.cloudinary.com/demoInInstance/image/upload/c_fill,h_10,w_10/sample');
1919
});
2020

2121

@@ -33,7 +33,7 @@ describe('Tests for Cloudinary instance', () => {
3333

3434
tImage.resize(fill(10, 10));
3535

36-
expect(tImage.toURL()).toBe('http://res.cloudinary.com/demoInInstance/image/upload/c_fill,h_10,w_10/sample');
36+
expect(tImage.toURL()).toBe('https://res.cloudinary.com/demoInInstance/image/upload/c_fill,h_10,w_10/sample');
3737
});
3838

3939
it ('throw error when useImage() is not called', () => {

__TESTS__/unit/actions/Adjust.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ describe('Tests for Transformation Action -- Adjust', () => {
122122
'o_100'
123123
].join('/');
124124

125-
expect(url).toBe(`http://res.cloudinary.com/demo/image/upload/${expectedToContain}/sample`);
125+
expect(url).toBe(`https://res.cloudinary.com/demo/image/upload/${expectedToContain}/sample`);
126126
});
127127

128128
it('tests replaceColor', () => {

__TESTS__/unit/actions/Background.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ describe('Tests for Transformation Action -- Background', () => {
3030
.setPublicID('sample')
3131
.toURL();
3232

33-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/b_red/sample');
33+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/b_red/sample');
3434
});
3535

3636

@@ -126,7 +126,7 @@ describe('Tests for Transformation Action -- Background', () => {
126126
.setPublicID('sample')
127127
.toURL();
128128

129-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/b_red,c_pad,h_250,w_250/sample');
129+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/b_red,c_pad,h_250,w_250/sample');
130130
});
131131

132132
it('Background.predominant().contrast().palette()', () => {

__TESTS__/unit/actions/Border.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe('Tests for Transformation Action -- Border', () => {
2323
.setPublicID('sample')
2424
.toURL();
2525

26-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/bo_7px_solid_red/sample');
26+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/bo_7px_solid_red/sample');
2727
});
2828

2929
it('Creates a cloudinaryURL with border and rgb #0000ff', () => {
@@ -33,7 +33,7 @@ describe('Tests for Transformation Action -- Border', () => {
3333
.setPublicID('sample')
3434
.toURL();
3535

36-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/bo_7px_solid_rgb:0000ff/sample');
36+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/bo_7px_solid_rgb:0000ff/sample');
3737
});
3838

3939
it('Creates a cloudinaryURL with border and rgb #FFF', () => {
@@ -43,7 +43,7 @@ describe('Tests for Transformation Action -- Border', () => {
4343
.setPublicID('sample')
4444
.toURL();
4545

46-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/bo_7px_solid_rgb:FFF/sample');
46+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/bo_7px_solid_rgb:FFF/sample');
4747
});
4848

4949
it('Creates a cloudinaryURL with border and rgb #FFFFFFFF', () => {
@@ -53,6 +53,6 @@ describe('Tests for Transformation Action -- Border', () => {
5353
.setPublicID('sample')
5454
.toURL();
5555

56-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/bo_7px_solid_rgb:FFFFFFFF/sample');
56+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/bo_7px_solid_rgb:FFFFFFFF/sample');
5757
});
5858
});

__TESTS__/unit/actions/Condition.test.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ describe('Tests for Transformation Action -- Condition', () => {
3333
.setPublicID('sample')
3434
.toURL();
3535

36-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/if_ar_eq_1.0/if_end/sample');
36+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/if_ar_eq_1.0/if_end/sample');
3737
});
3838

3939
it('Creates a cloudinaryURL with condition !=', () => {
@@ -44,7 +44,7 @@ describe('Tests for Transformation Action -- Condition', () => {
4444
.setPublicID('sample')
4545
.toURL();
4646

47-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/if_ar_ne_1.0/if_end/sample');
47+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/if_ar_ne_1.0/if_end/sample');
4848
});
4949

5050
it('Creates a cloudinaryURL with condition <', () => {
@@ -55,7 +55,7 @@ describe('Tests for Transformation Action -- Condition', () => {
5555
.setPublicID('sample')
5656
.toURL();
5757

58-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/if_ar_lt_1.0/if_end/sample');
58+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/if_ar_lt_1.0/if_end/sample');
5959
});
6060

6161
it('Creates a cloudinaryURL with condition >', () => {
@@ -66,7 +66,7 @@ describe('Tests for Transformation Action -- Condition', () => {
6666
.setPublicID('sample')
6767
.toURL();
6868

69-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/if_ar_gt_1.0/if_end/sample');
69+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/if_ar_gt_1.0/if_end/sample');
7070
});
7171

7272
it('Creates a cloudinaryURL with condition <=', () => {
@@ -77,7 +77,7 @@ describe('Tests for Transformation Action -- Condition', () => {
7777
.setPublicID('sample')
7878
.toURL();
7979

80-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/if_ar_lte_1.0/if_end/sample');
80+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/if_ar_lte_1.0/if_end/sample');
8181
});
8282

8383
it('Creates a cloudinaryURL with condition >=', () => {
@@ -88,7 +88,7 @@ describe('Tests for Transformation Action -- Condition', () => {
8888
.setPublicID('sample')
8989
.toURL();
9090

91-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/if_ar_gte_1.0/if_end/sample');
91+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/if_ar_gte_1.0/if_end/sample');
9292
});
9393

9494
it('Creates a cloudinaryURL with condition ar > 0.65 and w > 1000', () => {
@@ -100,7 +100,7 @@ describe('Tests for Transformation Action -- Condition', () => {
100100
.setPublicID('sample')
101101
.toURL();
102102

103-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/$a_30/if_ar_gt_0.65_and_w_gt_1000/if_end/sample');
103+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/$a_30/if_ar_gt_0.65_and_w_gt_1000/if_end/sample');
104104
});
105105

106106
it('Creates a cloudinaryURL with elseIf', () => {
@@ -114,7 +114,7 @@ describe('Tests for Transformation Action -- Condition', () => {
114114
.setPublicID('sample')
115115
.toURL();
116116

117-
expect(url).toBe('http://res.cloudinary.com/demo/image/upload/if_w_lte_500/c_crop,w_400/if_else/c_crop,w_500/if_end/sample');
117+
expect(url).toBe('https://res.cloudinary.com/demo/image/upload/if_w_lte_500/c_crop,w_400/if_else/c_crop,w_500/if_end/sample');
118118
});
119119

120120
});

0 commit comments

Comments
 (0)