Skip to content

Commit e1faa21

Browse files
author
Nir Maoz
authored
Refactor gravity types (#476)
1 parent fb7f333 commit e1faa21

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/actions/resize/ResizeAdvancedAction.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {ResizeSimpleAction} from "./ResizeSimpleAction.js";
2-
import {IGravity, IShortenGravity} from "../../qualifiers/gravity/GravityQualifier.js";
2+
import {IGravity} from "../../qualifiers/gravity/GravityQualifier.js";
33
import {Qualifier} from "../../internal/qualifier/Qualifier.js";
44
import {IActionModel} from "../../internal/models/IActionModel.js";
55
import {createGravityModel} from "../../internal/models/createGravityModel.js";
@@ -15,7 +15,7 @@ class ResizeAdvancedAction extends ResizeSimpleAction {
1515
* @description Which part of the original image to include.
1616
* @param {Qualifiers.Gravity} gravity
1717
*/
18-
gravity(gravity: IGravity | IShortenGravity): this {
18+
gravity(gravity: IGravity): this {
1919
this._actionModel.gravity = createGravityModel(gravity);
2020
const gravityQualifier = typeof gravity === "string" ? new Qualifier('g', gravity) : gravity;
2121

src/internal/models/createGravityModel.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {IGravity, IShortenGravity} from "../../qualifiers/gravity/GravityQualifier.js";
1+
import {IGravity} from "../../qualifiers/gravity/GravityQualifier.js";
22
import {ICompassGravity, isICompassGravity} from "../../qualifiers/gravity/compassGravity/CompassGravity.js";
33

44
export interface IGravityModel{
@@ -24,7 +24,7 @@ function createCompassGravityModel(compass: ICompassGravity): ICompassGravityMod
2424
* Create a model of given gravity
2525
* @param gravity
2626
*/
27-
export function createGravityModel(gravity: IGravity | IShortenGravity): ICompassGravityModel | string {
27+
export function createGravityModel(gravity: IGravity): ICompassGravityModel | string {
2828
const gravityString = (typeof gravity === "string" ? gravity : (gravity).qualifierValue) as string;
2929

3030
if (isICompassGravity(gravityString)) {

src/qualifiers/gravity/GravityQualifier.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ import {AutoFocus} from "../autoFocus.js";
88
import {CompassQualifier} from "./qualifiers/compass/CompassQualifier.js";
99
import {XYCenterGravity} from "./xyCenterGravity/XYCenterGravity.js";
1010

11-
export type IGravity = CompassGravity | AutoGravity | FocusOnGravity | XYCenterGravity;
11+
export type IGravityString = 'auto' | ICompassGravity;
12+
export type IGravity = CompassGravity | AutoGravity | FocusOnGravity | XYCenterGravity | IGravityString;
1213
export type IGravityValue = CompassQualifier | FocusOnValue | AutoFocus;
13-
export type IShortenGravity = 'auto' | ICompassGravity;
1414

1515
/**
1616
* @memberOf Gravity.GravityQualifier

0 commit comments

Comments
 (0)