Skip to content

Commit 7f972a3

Browse files
Fix handling of effect value
1 parent 145d0eb commit 7f972a3

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

src/Transformation/Qualifier/QualifierValue/FullListExpressionQualifierMultiValue.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ class FullListExpressionQualifierMultiValue extends ListExpressionQualifierMulti
2929
*/
3030
public function __toString()
3131
{
32-
$value = parent::__toString();
33-
if (StringUtils::contains($value, static::VALUE_DELIMITER)) {
34-
return '(' . $value . ')';
32+
$string = parent::__toString();
33+
if (!empty($string)) {
34+
return '(' . $string . ')';
3535
}
3636

37-
return $value;
37+
return $string;
3838
}
3939
}

tests/Unit/Transformation/Common/EffectTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,11 @@ public function testBackgroundRemoval()
301301
(string)Effect::backgroundRemoval()->fineEdges(false)
302302
);
303303

304+
self::assertEquals(
305+
'e_background_removal:fineedges_y;hints_(cat)',
306+
(string)Effect::backgroundRemoval()->fineEdges()->hints(ForegroundObject::cat())
307+
);
308+
304309
self::assertEquals(
305310
'e_background_removal:fineedges_y;hints_(cat;dog;bicycle)',
306311
(string)Effect::backgroundRemoval()->fineEdges()->hints(

0 commit comments

Comments
 (0)