Skip to content

Allow instance_class configuration even if serverless scaling config exists #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow instance_class configuration even if serverless scaling config exists #247

wants to merge 2 commits into from

Conversation

@paulerickson
Copy link

@paulerickson paulerickson commented Dec 11, 2024 •
edited
Loading

what

  • Don't override instance class based on serverlessv2 scaling configuration

why

  • serverlessv2 scaling configuration is a cluster attribute; it doesn't preclude provisioning provisioned instances in provisioned clusters

references

@paulerickson paulerickson requested review from a team as code owners December 11, 2024 22:44
@paulerickson paulerickson changed the title Allow instance_class configuration even if serverless scaling config … Allow instance_class configuration even if serverless scaling config exists Dec 11, 2024
@mergify mergify bot added the triage Needs triage label Dec 11, 2024
@paulerickson paulerickson force-pushed the non-serverless-instance-class branch from b8d0cdc to 282f77a Compare December 16, 2024 22:09
@paulerickson paulerickson force-pushed the non-serverless-instance-class branch from 282f77a to 5f5162b Compare December 17, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

triage Needs triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

serverlessv2_scaling_configuration does not imply instance class

1 participant

@paulerickson