Skip to content

Commit 1ffa38d

Browse files
huntiemeta-codesync[bot]
authored andcommitted
Replace Perf Issues warning icon with issue flag (facebook#54386)
Summary: Pull Request resolved: facebook#54386 Changelog: [Internal] Reviewed By: sbuggay Differential Revision: D86107870 fbshipit-source-id: 0cc408945376e053ddfe4ebdf07c51c1bf07b521
1 parent 30370f6 commit 1ffa38d

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorOverlayView.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,12 @@ internal class PerfMonitorOverlayView(
120120
setTextColor(Color.WHITE)
121121
typeface = TYPEFACE_BOLD
122122
val alertDrawable =
123-
context.getDrawable(android.R.drawable.ic_dialog_alert)?.apply {
123+
context.getDrawable(R.drawable.ic_perf_issue)?.apply {
124124
setBounds(
125125
0,
126126
1,
127-
dpToPx(TEXT_SIZE_PRIMARY).toInt(),
128-
dpToPx(TEXT_SIZE_PRIMARY).toInt() + 1,
127+
dpToPx(ISSUE_ICON_SIZE).toInt(),
128+
dpToPx(ISSUE_ICON_SIZE).toInt() + 1,
129129
)
130130
}
131131
setCompoundDrawables(alertDrawable, null, null, null)
@@ -214,6 +214,7 @@ internal class PerfMonitorOverlayView(
214214
private val COLOR_OVERLAY_BORDER = Color.parseColor("#6C6C6C")
215215
private val TEXT_SIZE_PRIMARY = 12f
216216
private val TEXT_SIZE_ACCESSORY = 10f
217+
private val ISSUE_ICON_SIZE = 15f
217218
private val TYPEFACE_BOLD = Typeface.create("sans-serif", Typeface.BOLD)
218219
}
219220
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<vector xmlns:android="http://schemas.android.com/apk/res/android"
3+
android:width="24dp"
4+
android:height="24dp"
5+
android:viewportWidth="960"
6+
android:viewportHeight="960">
7+
<path
8+
android:fillColor="@android:color/white"
9+
android:pathData="M80,880L80,160Q80,127 103.5,103.5Q127,80 160,80L800,80Q833,80 856.5,103.5Q880,127 880,160L880,640Q880,673 856.5,696.5Q833,720 800,720L240,720L80,880ZM480,600Q497,600 508.5,588.5Q520,577 520,560Q520,543 508.5,531.5Q497,520 480,520Q463,520 451.5,531.5Q440,543 440,560Q440,577 451.5,588.5Q463,600 480,600ZM440,440L520,440L520,200L440,200L440,440Z"/>
10+
</vector>

0 commit comments

Comments
 (0)