Skip to content

Commit 00ea203

Browse files
craig[bot]stevendanna
andcommitted
Merge #156753
156753: rangefeed: fix BenchmarkRangefeedBudget r=pav-kv a=stevendanna This benchmark was broken in f4d1c07 but was not noticed becuase benchmarks aren't run in CI. Fixes #156748 Release note: none Co-authored-by: Steven Danna <danna@cockroachlabs.com>
2 parents 91b1736 + 16ed3e1 commit 00ea203

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

pkg/kv/kvserver/rangefeed/bench_test.go

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -63,17 +63,20 @@ func BenchmarkRangefeed(b *testing.B) {
6363
// processes a set of events.
6464
func BenchmarkRangefeedBudget(b *testing.B) {
6565
for _, budget := range []bool{false, true} {
66-
b.Run(fmt.Sprintf("budget=%t", budget), func(b *testing.B) {
67-
var budgetSize int64
68-
if budget {
69-
budgetSize = math.MaxInt64
70-
}
71-
runBenchmarkRangefeed(b, benchmarkRangefeedOpts{
72-
opType: writeOpType,
73-
numRegistrations: 1,
74-
budget: budgetSize,
66+
for _, procType := range testTypes {
67+
b.Run(fmt.Sprintf("budget=%t/proc=%s", budget, procType), func(b *testing.B) {
68+
var budgetSize int64
69+
if budget {
70+
budgetSize = math.MaxInt64
71+
}
72+
runBenchmarkRangefeed(b, benchmarkRangefeedOpts{
73+
rangefeedTestType: procType,
74+
opType: writeOpType,
75+
numRegistrations: 1,
76+
budget: budgetSize,
77+
})
7578
})
76-
})
79+
}
7780
}
7881
}
7982

0 commit comments

Comments
 (0)