Skip to content

Commit 1fdf936

Browse files
craig[bot]sumeerbhola
andcommitted
Merge #156801
156801: ui: separate regular and elastic store graphs r=tbg a=sumeerbhola When they are in the same graph, it is hard to discern whether only elastic work is experiencing overload and delay. Example: <img width="659" height="571" alt="Screenshot 2025-11-03 at 2 13 59 PM" src="https://github.com/user-attachments/assets/1f4b2131-665f-40e0-8dac-37aa978dd184" /> <img width="653" height="567" alt="Screenshot 2025-11-03 at 2 14 12 PM" src="https://github.com/user-attachments/assets/219beccd-7511-48aa-9bc1-119f12d4b895" /> Epic: none Release note (ui change): The background (elastic) store graphs for exhausted duration, and the wait duration histogram have been separated from the foreground (regular) graphs. Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com>
2 parents 02c7429 + 5a8bb6e commit 1fdf936

File tree

1 file changed

+26
-4
lines changed
  • pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards

1 file changed

+26
-4
lines changed

pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/overload.tsx

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,11 @@ export default function (props: GraphDashboardProps) {
6262
</LineGraph>,
6363

6464
<LineGraph
65-
title="Admission IO Tokens Exhausted Duration Per Second"
65+
title="Admission Foreground IO Tokens Exhausted Duration Per Second"
6666
sources={storeSources}
6767
tenantSource={tenantSource}
6868
showMetricsInTooltip={true}
69-
tooltip={`Relative time the node had exhausted IO tokens for all IO-bound work per second of wall time, measured in microseconds/second. Increased IO token exhausted duration indicates IO resource exhaustion.`}
69+
tooltip={`Relative time the store had exhausted foreground (regular) IO tokens for all IO-bound work per second of wall time, measured in microseconds/second. Increased IO token exhausted duration indicates IO resource exhaustion.`}
7070
>
7171
<Axis label="Duration (micros/sec)">
7272
{storeMetrics(
@@ -79,6 +79,17 @@ export default function (props: GraphDashboardProps) {
7979
storeIDsByNodeID,
8080
"regular (foreground)",
8181
)}
82+
</Axis>
83+
</LineGraph>,
84+
85+
<LineGraph
86+
title="Admission Background IO Tokens Exhausted Duration Per Second"
87+
sources={storeSources}
88+
tenantSource={tenantSource}
89+
showMetricsInTooltip={true}
90+
tooltip={`Relative time the store had exhausted background (elastic) IO tokens for all IO-bound work per second of wall time, measured in microseconds/second. Increased IO token exhausted duration indicates IO resource exhaustion.`}
91+
>
92+
<Axis label="Duration (micros/sec)">
8293
{storeMetrics(
8394
{
8495
name: "cr.store.admission.granter.elastic_io_tokens_exhausted_duration.kv",
@@ -168,11 +179,11 @@ export default function (props: GraphDashboardProps) {
168179
</LineGraph>,
169180

170181
<LineGraph
171-
title="Admission Queueing Delay p99 – Store"
182+
title="Admission Queueing Delay p99 – Foreground (Regular) Store"
172183
sources={storeSources}
173184
tenantSource={tenantSource}
174185
showMetricsInTooltip={true}
175-
tooltip={`The 99th percentile latency of requests waiting in the Admission Control store queue.`}
186+
tooltip={`The 99th percentile latency of requests waiting in the foreground (regular) Admission Control store queue.`}
176187
>
177188
<Axis units={AxisUnits.DurationMillis} label="Write Delay Duration">
178189
{storeMetrics(
@@ -184,6 +195,17 @@ export default function (props: GraphDashboardProps) {
184195
storeIDsByNodeID,
185196
"KV",
186197
)}
198+
</Axis>
199+
</LineGraph>,
200+
201+
<LineGraph
202+
title="Admission Queueing Delay p99 – Background (Elastic) Store"
203+
sources={storeSources}
204+
tenantSource={tenantSource}
205+
showMetricsInTooltip={true}
206+
tooltip={`The 99th percentile latency of requests waiting in the background (elastic) Admission Control store queue.`}
207+
>
208+
<Axis units={AxisUnits.DurationMillis} label="Write Delay Duration">
187209
{storeMetrics(
188210
{
189211
name: "cr.store.admission.wait_durations.elastic-stores-p99",

0 commit comments

Comments
 (0)