You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
156122: sql/inspect: fix LTREE[] handling in query bounds r=spilchen a=spilchen
INSPECT builds query bounds from primary key column types. When a table had an LTREE[] column, the bound datums could be interpreted as string[] by the query engine, causing errors like:
```
unsupported comparison operator: <ltree[]> >= <string[]>
```
This happened because the datum formatting omitted type information for array elements. For example, ['j.k.l']::LTREE[] was formatted as ARRAY['j.k.l'], which loses the cast. The fix marks the LTREE type as ambiguous so the formatter includes explicit type casts, avoiding mismatches in distributed queries.
While testing, I also added placeholder values to the logged query in inspect issues (previously only the query text was shown).
Informs: #155483Closes: #156121
Epic: CRDB-55075
Release note: none
156183: bootstrap: enable 25.4 mixed-cluster logic tests r=fqazi a=celiala
## bootstrap: enable 25.4 mixed-cluster logic tests
This change enables mixed-cluster logic tests for version 25.4 by adding bootstrap data from release-25.4 and configuring the local-mixed-25.4 test configuration.
### Changes
The bootstrap data was obtained by running (on release-25.4 branch):
```bash
./dev build sql-bootstrap-data && bin/sql-bootstrap-data
```
This PR includes:
- Added bootstrap data files (25_4_system.keys/sha256, 25_4_tenant.keys/sha256)
- Updated initial_values.go with V25_4 mapping
- Added local-mixed-25.4 logictest configuration
- Generated test files for local-mixed-25.4 config
- Updated logictests with skipif directives for local-mixed-25.4
- Added comprehensive runbook at `pkg/clusterversion/CLAUDE.md` documenting the M.2 process
### Documentation
A comprehensive runbook has been added to `pkg/clusterversion/CLAUDE.md` (following the pattern of R.1, R.2, and M.1 runbooks). This documents:
- Step-by-step checklist for future M.2 tasks
- Common errors and solutions
- File locations and patterns
- Testing procedures
This should make future quarterly M.2 tasks easier to execute.
---
Part of M.2 "Enable mixed-cluster logic tests" checklist from https://github.com/cockroachdb/cockroach/blob/master/pkg/clusterversion/README.md
Following the example from previous M.2 work.
Epic: none
Release note: None
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Matt Spilchen <matt.spilchen@cockroachlabs.com>
Co-authored-by: Celia La <celia@cockroachlabs.com>
0 commit comments