Skip to content

Commit 3a7f8cd

Browse files
craig[bot]msbutlerrafiss
committed
156955: workflows: auto DR tests after a month r=jeffswenson a=msbutler Since the artifacts will have been deleted, close out test. Epic: none Release note: none 156969: roachtest: disable max object count for large_schema_benchmark r=rafiss a=rafiss This test is intentionally using a large number of tables, so we should disable the guardrail. fixes #156188 fixes #156721 Release note: None Co-authored-by: Michael Butler <butler@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
3 parents 21f0e95 + f0e1c1e + 62fd29d commit 3a7f8cd

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

.github/workflows/test-failure-stale.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@ jobs:
3030
days-before-pr-stale: 99999
3131
days-before-issue-stale: 30
3232
days-before-close: 5
33-
any-of-labels: 'T-kv,T-sql-foundations'
33+
any-of-labels: 'T-kv,T-sql-foundations,T-disaster-recovery'
3434
only-labels: 'C-test-failure'
3535
exempt-issue-labels: 'release-blocker,skipped-test,X-nostale'

pkg/cmd/roachtest/tests/large_schema_benchmark.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,12 @@ func registerLargeSchemaBenchmark(r registry.Registry, numTables int, isMultiReg
170170
// a large number of tables
171171
_, err = conn.Exec("SET CLUSTER SETTING kv.transaction.internal.max_auto_retries=500")
172172
require.NoError(t, err)
173+
// Disable the schema object count limit to allow creating 40,000+
174+
// tables. This is a guardrail that prevents unbounded growth of the
175+
// descriptor table, but for this benchmark we intentionally want to
176+
// test with a large number of tables.
177+
_, err = conn.Exec("SET CLUSTER SETTING sql.schema.approx_max_object_count = 0")
178+
require.NoError(t, err)
173179
// Create a user that will be used for authentication for the REST
174180
// API calls.
175181
_, err = conn.Exec("CREATE USER roachadmin password 'roacher'")

0 commit comments

Comments
 (0)