upgrade: remove unused SQLStats testing knobs

Release note: None

Author: yuzefovich

pkg/server/server_sql.go

@@ -1270,7 +1270,6 @@ func newSQLServer(ctx context.Context, cfg sqlServerArgs) (*SQLServer, error) {
 		var c upgrade.Cluster
 		var systemDeps upgrade.SystemDeps
 		keyVisKnobs, _ := cfg.TestingKnobs.KeyVisualizer.(*keyvisualizer.TestingKnobs)
-		sqlStatsKnobs, _ := cfg.TestingKnobs.SQLStatsKnobs.(*sqlstats.TestingKnobs)
 		upgradeKnobs, _ := cfg.TestingKnobs.UpgradeManager.(*upgradebase.TestingKnobs)
 		if codec.ForSystemTenant() {
 			c = upgradecluster.New(upgradecluster.ClusterConfig{
@@ -1296,7 +1295,6 @@ func newSQLServer(ctx context.Context, cfg sqlServerArgs) (*SQLServer, error) {
 			JobRegistry:        jobRegistry,
 			Stopper:            cfg.stopper,
 			KeyVisKnobs:        keyVisKnobs,
-			SQLStatsKnobs:      sqlStatsKnobs,
 			TenantInfoAccessor: cfg.tenantConnect,
 			TestingKnobs:       upgradeKnobs,
 		}

pkg/upgrade/BUILD.bazel

@@ -28,7 +28,6 @@ go_library(
         "//pkg/sql/catalog/resolver",
         "//pkg/sql/isql",
         "//pkg/sql/sessiondata",
-        "//pkg/sql/sqlstats",
         "//pkg/upgrade/upgradebase",
         "//pkg/util/retry",
         "//pkg/util/stop",

pkg/upgrade/system_upgrade.go

@@ -18,7 +18,6 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/server/serverpb"
 	"github.com/cockroachdb/cockroach/pkg/settings/cluster"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/descs"
-	"github.com/cockroachdb/cockroach/pkg/sql/sqlstats"
 	"github.com/cockroachdb/cockroach/pkg/upgrade/upgradebase"
 	"github.com/cockroachdb/cockroach/pkg/util/retry"
 	"github.com/cockroachdb/cockroach/pkg/util/stop"
@@ -121,7 +120,6 @@ type SystemDeps struct {
 	JobRegistry        *jobs.Registry
 	Stopper            *stop.Stopper
 	KeyVisKnobs        *keyvisualizer.TestingKnobs
-	SQLStatsKnobs      *sqlstats.TestingKnobs
 	TenantInfoAccessor mtinfo.ReadFromTenantInfoAccessor
 	TestingKnobs       *upgradebase.TestingKnobs
 }