Skip to content

Commit 6d96fe6

Browse files
craig[bot]stevendannajeffswenson
committed
156376: roachtest: add scaffolding for new kv rangefeed tests r=stevendanna a=stevendanna This adds a new kv-rangefeed test suite. These roachtests are aimed at understanding the behavior of the server-side rangefeed components. To achieve this, our plan is: 1) Use a sink with a known capacity such that we can differentiate between the "correctly provisioned" and "under-provisioned" sink cases. 2) Assert that any sink that is correctly provisioned eventually catches up. 3) Assert that regardless of sink provisioning, we never impact p99 foreground SQL latency. This adds a small example test along with most of the scaffolding needed to add more tests in future PRs. Epic: CRDB-55203 Release note: None 156793: logical: support array primary keys in the crud writer r=jeffswenson a=jeffswenson This adds a second point select row reader to the LDR crud writer. This is a work around for #32552. This change also includes a small fix to the batch row reader. It now initializes the array parameter with the canonical type. This is required because the arguments come from the cdc event decoder and the event decoder always returns canonical datums. Release note: none Fixes: #148303 Co-authored-by: Steven Danna <danna@cockroachlabs.com> Co-authored-by: Jeff Swenson <jeffswenson@betterthannull.com>
3 parents 42eae18 + 47c00a2 + 277bdcf commit 6d96fe6

File tree

10 files changed

+875
-19
lines changed

10 files changed

+875
-19
lines changed

pkg/cmd/roachtest/tests/BUILD.bazel

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ go_library(
104104
"kerberos_connection_stress.go",
105105
"knex.go",
106106
"kv.go",
107+
"kv_rangefeed.go",
107108
"kvbench.go",
108109
"large_kv.go",
109110
"large_schema_backup_restore.go",
@@ -375,6 +376,7 @@ go_test(
375376
"blocklist_test.go",
376377
"cdc_helper_test.go",
377378
"drt_test.go",
379+
"kv_rangefeed_test.go",
378380
"nodejs_helpers_test.go",
379381
"query_comparison_util_test.go",
380382
"restore_test.go",

0 commit comments

Comments
 (0)