reports: change logging channel

Author: tbg

pkg/kv/kvserver/reports/constraint_stats_report.go

@@ -387,12 +387,12 @@ func (v *constraintConformanceVisitor) init(ctx context.Context) {
 	maxObjectID, err := v.cfg.GetLargestObjectID(
 		0 /* maxReservedDescID - return the largest ID in the config */, keys.PseudoTableIDs)
 	if err != nil {
-		log.Dev.Fatalf(ctx, "unexpected failure to compute max object id: %s", err)
+		log.KvDistribution.Fatalf(ctx, "unexpected failure to compute max object id: %s", err)
 	}
 	for i := config.ObjectID(1); i <= maxObjectID; i++ {
 		zone, err := getZoneByID(i, v.cfg)
 		if err != nil {
-			log.Dev.Fatalf(ctx, "unexpected failure to compute max object id: %s", err)
+			log.KvDistribution.Fatalf(ctx, "unexpected failure to compute max object id: %s", err)
 		}
 		if zone == nil {
 			continue

pkg/kv/kvserver/reports/replication_stats_report.go

@@ -286,12 +286,12 @@ func (v *replicationStatsVisitor) init(ctx context.Context) {
 		0 /* maxReservedDescID - return the largest ID in the config */, keys.PseudoTableIDs,
 	)
 	if err != nil {
-		log.Dev.Fatalf(ctx, "unexpected failure to compute max object id: %s", err)
+		log.KvDistribution.Fatalf(ctx, "unexpected failure to compute max object id: %s", err)
 	}
 	for i := config.ObjectID(1); i <= maxObjectID; i++ {
 		zone, err := getZoneByID(i, v.cfg)
 		if err != nil {
-			log.Dev.Fatalf(ctx, "unexpected failure to compute max object id: %s", err)
+			log.KvDistribution.Fatalf(ctx, "unexpected failure to compute max object id: %s", err)
 		}
 		if zone == nil {
 			continue

pkg/kv/kvserver/reports/reporter.go

@@ -151,7 +151,7 @@ func (stats *Reporter) Start(ctx context.Context, stopper *stop.Stopper) {
 					if err := stats.update(
 						ctx, &constraintsSaver, &replStatsSaver, &criticalLocSaver,
 					); err != nil {
-						log.Dev.Errorf(ctx, "failed to generate replication reports: %s", err)
+						log.KvDistribution.Errorf(ctx, "failed to generate replication reports: %s", err)
 					}
 				}
 				timer.Reset(interval)
@@ -230,7 +230,7 @@ func (stats *Reporter) update(
 		&constraintConfVisitor, &localityStatsVisitor, &replicationStatsVisitor,
 	); err != nil {
 		if errors.HasType(err, (*visitorError)(nil)) {
-			log.Dev.Errorf(ctx, "some reports have not been generated: %s", err)
+			log.KvDistribution.Errorf(ctx, "some reports have not been generated: %s", err)
 		} else {
 			return errors.Wrap(err, "failed to compute constraint conformance report")
 		}
@@ -270,7 +270,7 @@ func (stats *Reporter) meta1LeaseHolderStore(ctx context.Context) *kvserver.Stor
 		return nil
 	}
 	if err != nil {
-		log.Dev.Fatalf(ctx, "unexpected error when visiting stores: %s", err)
+		log.KvDistribution.Fatalf(ctx, "unexpected error when visiting stores: %s", err)
 	}
 	if repl.OwnsValidLease(ctx, store.Clock().NowAsClockTimestamp()) {
 		return store
@@ -707,7 +707,7 @@ func (r *meta2RangeIter) readBatch(ctx context.Context) (retErr error) {
 	defer func() { r.handleErr(ctx, retErr) }()
 
 	if len(r.buffer) > 0 {
-		log.Dev.Fatalf(ctx, "buffer not exhausted: %d keys remaining", len(r.buffer))
+		log.KvDistribution.Fatalf(ctx, "buffer not exhausted: %d keys remaining", len(r.buffer))
 	}
 	if r.txn == nil {
 		r.txn = r.db.NewTxn(ctx, "rangeStoreImpl")
@@ -755,7 +755,7 @@ func (r *meta2RangeIter) handleErr(ctx context.Context, err error) {
 		return
 	}
 	if errors.HasType(err, (*kvpb.TransactionRetryWithProtoRefreshError)(nil)) {
-		log.Dev.Warningf(ctx, "unexpected retryable error from "+
+		log.KvDistribution.Warningf(ctx, "unexpected retryable error from "+
 			"read-only transaction with fixed read timestamp: %s", err)
 	}
 	if r.txn != nil {