tmp

Author: blathers-crl[bot]

.bazelrc

@@ -85,9 +85,6 @@ test:ci --test_output=errors
 # Put all tmp artifacts in /artifacts/tmp.
 test:ci --test_tmpdir=/artifacts/tmp
 
-# TODO(ricky): This should be v1.0.0.
-build:fips --@io_bazel_rules_go//go/config:gofips140=latest
-
 build:cross --stamp
 
 # Cross-compilation configurations. Add e.g. --config=crosslinux to turn these on.
@@ -104,7 +101,7 @@ build:crosslinuxfips '--workspace_status_command=./build/bazelutil/stamp.sh -t x
 build:crosslinuxfips --config=crosslinuxfipsbase
 build:crosslinuxfipsbase --platforms=//build/toolchains:cross_linux
 build:crosslinuxfipsbase --config=cross
-build:crosslinuxfipsbase --config=fips
+build:crosslinuxfipsbase --@io_bazel_rules_go//go/toolchain:sdk_version=1.23.12fips
 build:crosswindows '--workspace_status_command=./build/bazelutil/stamp.sh -t x86_64-w64-mingw32'
 build:crosswindows --config=crosswindowsbase
 build:crosswindowsbase --platforms=//build/toolchains:cross_windows

.github/CODEOWNERS

@@ -71,11 +71,8 @@
 /pkg/sql/executor_statement_metrics.go @cockroachdb/obs-prs
 /pkg/sql/flowinfra/          @cockroachdb/sql-queries-prs
 /pkg/sql/hints/              @cockroachdb/sql-queries-prs
-/pkg/sql/parser/             @cockroachdb/sql-queries-prs
 /pkg/sql/physicalplan/       @cockroachdb/sql-queries-prs
 /pkg/sql/row*                @cockroachdb/sql-queries-prs
-/pkg/sql/sem/tree/           @cockroachdb/sql-queries-prs
-/pkg/sql/types/              @cockroachdb/sql-queries-prs
 /pkg/sql/control_job*        @cockroachdb/sql-queries-prs @cockroachdb/jobs-prs
 /pkg/sql/job_exec_context*   @cockroachdb/sql-queries-prs @cockroachdb/jobs-prs
 /pkg/sql/delegate/*job*.go   @cockroachdb/jobs-prs @cockroachdb/disaster-recovery
@@ -95,10 +92,14 @@
 /pkg/sql/tablemetadatacache/  @cockroachdb/obs-prs
 /pkg/ccl/testccl/sqlstatsccl/ @cockroachdb/obs-prs
 
+/pkg/sql/sem/tree/           @cockroachdb/sql-syntax-prs
+/pkg/sql/parser/             @cockroachdb/sql-syntax-prs
+/pkg/sql/lex/                @cockroachdb/sql-syntax-prs
+/pkg/sql/show_create*.go     @cockroachdb/sql-syntax-prs
+/pkg/sql/types/              @cockroachdb/sql-syntax-prs
+
 /pkg/sql/crdb_internal.go    @cockroachdb/sql-foundations
 /pkg/sql/pg_catalog.go       @cockroachdb/sql-foundations
-/pkg/sql/show_create*.go     @cockroachdb/sql-foundations
-/pkg/sql/lex/                @cockroachdb/sql-foundations
 /pkg/sql/pgwire/             @cockroachdb/sql-foundations @cockroachdb/product-security
 /pkg/sql/pgwire/auth.go      @cockroachdb/sql-foundations @cockroachdb/security-engineering
 /pkg/sql/sem/builtins/       @cockroachdb/sql-foundations

.github/workflows/cluster-ui-release.yml

@@ -58,7 +58,7 @@ jobs:
       run: |
         PACKAGE_VERSION=$(cat ./package.json | jq -r ".version");
         VERSIONS=$(npm view @cockroachlabs/cluster-ui versions)
-        if [[ $VERSIONS == *\'"$PACKAGE_VERSION"\'* ]]; then
+        if [[ $VERSIONS == *"$PACKAGE_VERSION"* ]]; then
           echo "published=yes" >> $GITHUB_OUTPUT
           echo
           echo "🛑 Cluster UI package version $PACKAGE_VERSION is already published"

.github/workflows/microbenchmarks-ci.yaml

@@ -47,7 +47,7 @@ jobs:
           pkg: ${{ env.PACKAGE }}
   run-group-1:
     runs-on: [self-hosted, ubuntu_2004_microbench]
-    timeout-minutes: 90
+    timeout-minutes: 60
     needs: [base, head]
     steps:
       - name: Checkout
@@ -60,7 +60,7 @@ jobs:
           group: 1
   run-group-2:
     runs-on: [self-hosted, ubuntu_2004_microbench]
-    timeout-minutes: 90
+    timeout-minutes: 60
     needs: [base, head]
     steps:
       - name: Checkout

.github/workflows/pr-analyzer-threestage.yml

@@ -32,7 +32,6 @@ jobs:
           - "release-24.3"
           - "release-25.2"
           - "release-25.3"
-          - "release-25.4"
     name: Update pkg/testutils/release/cockroach_releases.yaml on ${{ matrix.branch }}
     runs-on: ubuntu-latest
     steps:

.github/workflows/update_releases.yaml

@@ -40,7 +40,6 @@ Adam Pantel <adam@cockroachlabs.com>
 Adam Spindler <spindler@cockroachlabs.com>
 Adam Storm <storm@cockroachlabs.com>
 Adam Yao <adam.yao.qinglin@gmail.com>
-Aditya Madan <aditya.madan@cockroachlabs.com>
 Aditya Maru <adityamaru@gmail.com> <@cockroachlabs.com>
 Adwit Tumuluri <adwit.tumuluri@gmail.com> <@cockroachlabs.com>
 Aerin Freilich <aerin.freilich@cockroachlabs.com>
@@ -397,7 +396,6 @@ Nick Travers <travers@cockroachlabs.com>
 Nick Vigilante <vigilante@cockroachlabs.com>
 Nihal Pednekar <nihal@cockroachlabs.com> <pednekar.nihal@gmail.com>
 Nikhil Benesch <nikhil.benesch@gmail.com> <@cockroachlabs.com>
-Nishant Gupta <nishant.gupta@cockroachlabs.com>
 Nishant Gupta <nishant.gupta@rubrik.com>
 Nishanth Nalluri <nishanth.nalluri@cockroachlabs.com>
 Noah Thompson <noah.thompson@cockroachlabs.com>
@@ -506,7 +504,6 @@ Stephen Yang <stephen.yang@cockroachlabs.com>
 Steven Danna <danna@cockroachlabs.com>
 Steven Hand <@cockroachlabs.com> hand <@cockroachlabs.com> hand-crdb <@cockroachlabs.com>
 Steven Hubbard <steven.c.hubbard@gmail.com> <hubbard@cockroachlabs.com>
-Sujatha Sivaramakrishnan <sujatha.sivaramakrishnan@cockroachlabs.com>
 sum12 <sumitjami@gmail.com>
 Sumeer Bhola <sumeer@cockroachlabs.com> sumeerbhola <sumeer@cockroachlabs.com>
 Suraj Rao <suraj.rao@cockroachlabs.com> <suraj_rao@berkeley.edu>

AUTHORS

@@ -178,10 +178,7 @@ nogo(
         "@org_golang_x_tools//go/analysis/passes/lostcancel:go_default_library",
         "@org_golang_x_tools//go/analysis/passes/nilfunc:go_default_library",
         "@org_golang_x_tools//go/analysis/passes/nilness:go_default_library",
-        # TODO(ricky): With the Go 1.25 upgrade, this started failing with errors
-        # like `VERSION="5.19.0"`. I don't know what that means and it doesn't seem
-        # significant to us, so disabling for now.
-        # "@org_golang_x_tools//go/analysis/passes/pkgfact:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/pkgfact:go_default_library",
         "@org_golang_x_tools//go/analysis/passes/printf:go_default_library",
         "@org_golang_x_tools//go/analysis/passes/shift:go_default_library",
         "@org_golang_x_tools//go/analysis/passes/sortslice:go_default_library",