gc: change logging channel

Author: tbg

pkg/kv/kvserver/gc/gc.go

@@ -379,7 +379,7 @@ func Run(
 		if errors.Is(err, ctx.Err()) {
 			return Info{}, err
 		}
-		log.Dev.Warningf(ctx, "while gc'ing local key range: %s", err)
+		log.KvExec.Warningf(ctx, "while gc'ing local key range: %s", err)
 	}
 
 	// Clean up the AbortSpan.
@@ -388,7 +388,7 @@ func Run(
 		if errors.Is(err, ctx.Err()) {
 			return Info{}, err
 		}
-		log.Dev.Warningf(ctx, "while gc'ing abort span: %s", err)
+		log.KvExec.Warningf(ctx, "while gc'ing abort span: %s", err)
 	}
 
 	log.Eventf(ctx, "GC'ed keys; stats %+v", info)
@@ -445,7 +445,7 @@ func processReplicatedKeyRange(
 				excludeUserKeySpan = true
 				info.ClearRangeSpanOperations++
 			} else {
-				log.Dev.Warningf(ctx, "failed to perform GC clear range operation on range %s: %s",
+				log.KvExec.Warningf(ctx, "failed to perform GC clear range operation on range %s: %s",
 					desc.String(), err)
 				info.ClearRangeSpanFailures++
 			}
@@ -580,7 +580,7 @@ func processReplicatedLocks(
 					if errors.Is(err, ctx.Err()) {
 						return err
 					}
-					log.Dev.Warningf(ctx, "failed to cleanup intents batch: %v", err)
+					log.KvExec.Warningf(ctx, "failed to cleanup intents batch: %v", err)
 				}
 			}
 		}
@@ -606,7 +606,7 @@ func processReplicatedLocks(
 		if errors.Is(err, ctx.Err()) {
 			return err
 		}
-		log.Dev.Warningf(ctx, "failed to cleanup intents batch: %v", err)
+		log.KvExec.Warningf(ctx, "failed to cleanup intents batch: %v", err)
 	}
 	return nil
 }
@@ -934,7 +934,7 @@ func (b *gcKeyBatcher) maybeFlushPendingBatches(ctx context.Context) (err error)
 			// safe to continue because we bumped the GC
 			// thresholds. We may leave some inconsistent history
 			// behind, but nobody can read it.
-			log.Dev.Warningf(ctx, "failed to GC keys with clear range: %v", err)
+			log.KvExec.Warningf(ctx, "failed to GC keys with clear range: %v", err)
 			b.info.ClearRangeSpanFailures++
 		}
 		b.clearRangeCounters.updateGcInfo(b.info)
@@ -981,7 +981,7 @@ func (b *gcKeyBatcher) flushPointsBatch(ctx context.Context, batch *pointsBatch)
 		// safe to continue because we bumped the GC
 		// thresholds. We may leave some inconsistent history
 		// behind, but nobody can read it.
-		log.Dev.Warningf(ctx, "failed to GC a batch of keys: %v", err)
+		log.KvExec.Warningf(ctx, "failed to GC a batch of keys: %v", err)
 	}
 	batch.gcBatchCounters.updateGcInfo(b.info)
 	b.totalMemUsed -= batch.gcBatchCounters.memUsed
@@ -1194,7 +1194,7 @@ func processLocalKeyRange(
 	gcer PureGCer,
 ) error {
 	b := makeBatchingInlineGCer(gcer, func(err error) {
-		log.Dev.Warningf(ctx, "failed to GC from local key range: %s", err)
+		log.KvExec.Warningf(ctx, "failed to GC from local key range: %s", err)
 	})
 	defer b.Flush(ctx)
 
@@ -1286,7 +1286,7 @@ func processAbortSpan(
 	gcer PureGCer,
 ) error {
 	b := makeBatchingInlineGCer(gcer, func(err error) {
-		log.Dev.Warningf(ctx, "unable to GC from abort span: %s", err)
+		log.KvExec.Warningf(ctx, "unable to GC from abort span: %s", err)
 	})
 	defer b.Flush(ctx)
 	abortSpan := abortspan.New(rangeID)

pkg/kv/kvserver/gc/gc_random_test.go

@@ -435,9 +435,9 @@ func assertLiveData(
 	// 1000 elements is ok, but 10k or 100k entries might become unreadable.
 	if log.V(1) {
 		ctx := context.Background()
-		log.Dev.Info(ctx, "Expected data:")
+		log.KvExec.Info(ctx, "Expected data:")
 		for _, l := range formatTable(engineData(t, before, desc), desc.StartKey.AsRawKey()) {
-			log.Dev.Infof(ctx, "%s", l)
+			log.KvExec.Infof(ctx, "%s", l)
 		}
 	}
 

pkg/kv/kvserver/gc/gc_test.go

@@ -1145,14 +1145,14 @@ func runTest(t *testing.T, data testRunData, verify gcVerifier) {
 	expectedStats := dataItems.liveDistribution().setupTest(t, ctrlEng, desc)
 
 	if log.V(1) {
-		log.Dev.Info(ctx, "Expected data:")
+		log.KvExec.Info(ctx, "Expected data:")
 		for _, l := range formatTable(engineData(t, ctrlEng, desc), tablePrefix) {
-			log.Dev.Infof(ctx, "%s", l)
+			log.KvExec.Infof(ctx, "%s", l)
 		}
 
-		log.Dev.Info(ctx, "Actual data:")
+		log.KvExec.Info(ctx, "Actual data:")
 		for _, l := range formatTable(engineData(t, eng, desc), tablePrefix) {
-			log.Dev.Infof(ctx, "%s", l)
+			log.KvExec.Infof(ctx, "%s", l)
 		}
 	}