chore: update Nx to v21 (#1082)

Precondition:
- push-based/nx-verdaccio#90

This PR includes:
- nx migrate latest
- run migrations
- small fixes for new Nx version in helpers
- due to version updates typescript and eslint tests changes. same for
lighthouse e2e tests

<details>
<summary>migrations.json</summary>
```json
{
  "migrations": [
    {
      "version": "20.0.0-beta.7",
      "description": "Migration for v20.0.0-beta.7",
      "implementation": "./src/migrations/update-20-0-0/move-use-daemon-process",
      "package": "nx",
      "name": "move-use-daemon-process"
    },
    {
      "version": "20.0.1",
      "description": "Set `useLegacyCache` to true for migrating workspaces",
      "implementation": "./src/migrations/update-20-0-1/use-legacy-cache",
      "x-repair-skip": true,
      "package": "nx",
      "name": "use-legacy-cache"
    },
    {
      "version": "21.0.0-beta.8",
      "description": "Removes the legacy cache configuration from nx.json",
      "implementation": "./src/migrations/update-21-0-0/remove-legacy-cache",
      "package": "nx",
      "name": "remove-legacy-cache"
    },
    {
      "version": "21.0.0-beta.8",
      "description": "Removes the legacy cache configuration from nx.json",
      "implementation": "./src/migrations/update-21-0-0/remove-custom-tasks-runner",
      "package": "nx",
      "name": "remove-custom-tasks-runner"
    },
    {
      "version": "21.0.0-beta.11",
      "description": "Updates release version config based on the breaking changes in Nx v21",
      "implementation": "./src/migrations/update-21-0-0/release-version-config-changes",
      "package": "nx",
      "name": "release-version-config-changes"
    },
    {
      "version": "21.0.0-beta.11",
      "description": "Updates release changelog config based on the breaking changes in Nx v21",
      "implementation": "./src/migrations/update-21-0-0/release-changelog-config-changes",
      "package": "nx",
      "name": "release-changelog-config-changes"
    },
    {
      "version": "21.1.0-beta.2",
      "description": "Adds **/nx-rules.mdc and **/nx.instructions.md to .gitignore if not present",
      "implementation": "./src/migrations/update-21-1-0/add-gitignore-entry",
      "package": "nx",
      "name": "21-1-0-add-ignore-entries-for-nx-rule-files"
    },
    {
      "version": "20.0.4-beta.0",
      "description": "Add gitignore entry for temporary vite config files.",
      "implementation": "./src/migrations/update-20-0-4/add-vite-temp-files-to-git-ignore",
      "package": "@nx/vite",
      "name": "update-20-0-4"
    },
    {
      "version": "20.0.6-beta.0",
      "description": "Add gitignore entry for temporary vite config files and remove previous incorrect glob.",
      "implementation": "./src/migrations/update-20-0-4/add-vite-temp-files-to-git-ignore",
      "package": "@nx/vite",
      "name": "update-20-0-6"
    },
    {
      "version": "20.3.0-beta.2",
      "description": "Add gitignore entry for temporary vitest config files.",
      "implementation": "./src/migrations/update-20-3-0/add-vitest-temp-files-to-git-ignore",
      "package": "@nx/vite",
      "name": "update-20-3-0"
    },
    {
      "version": "20.5.0-beta.2",
      "description": "Install jiti as a devDependency to allow vite to parse TS postcss files.",
      "implementation": "./src/migrations/update-20-5-0/install-jiti",
      "package": "@nx/vite",
      "name": "update-20-5-0-install-jiti"
    },
    {
      "version": "20.5.0-beta.3",
      "description": "Update resolve.conditions to include defaults that are no longer provided by Vite.",
      "implementation": "./src/migrations/update-20-5-0/update-resolve-conditions",
      "package": "@nx/vite",
      "name": "update-20-5-0-update-resolve-conditions"
    },
    {
      "version": "20.5.0-beta.3",
      "description": "Add vite config temporary files to the ESLint configuration ignore patterns if ESLint is used.",
      "implementation": "./src/migrations/update-20-5-0/eslint-ignore-vite-temp-files",
      "package": "@nx/vite",
      "name": "eslint-ignore-vite-temp-files"
    },
    {
      "cli": "nx",
      "version": "20.2.0-beta.2",
      "description": "Update the ModuleFederationConfig import use @nx/module-federation.",
      "factory": "./src/migrations/update-20-2-0/migrate-mf-imports-to-new-package",
      "package": "@nx/react",
      "name": "update-20-2-0-update-module-federation-config-import"
    },
    {
      "cli": "nx",
      "version": "20.2.0-beta.2",
      "description": "Update the withModuleFederation import use @nx/module-federation/webpack.",
      "factory": "./src/migrations/update-20-2-0/migrate-with-mf-import-to-new-package",
      "package": "@nx/react",
      "name": "update-20-2-0-update-with-module-federation-import"
    },
    {
      "cli": "nx",
      "version": "20.3.0-beta.2",
      "description": "If workspace includes Module Federation projects, ensure the new @nx/module-federation package is installed.",
      "factory": "./src/migrations/update-20-3-0/ensure-nx-module-federation-package",
      "package": "@nx/react",
      "name": "ensure-nx-module-federation-package"
    },
    {
      "cli": "nx",
      "version": "20.4.0-beta.0",
      "description": "Add NX_MF_DEV_REMOTES to inputs for task hashing when '@nx/webpack:webpack' or '@nx/rspack:rspack' is used for Module Federation.",
      "factory": "./src/migrations/update-18-0-0/add-mf-env-var-to-target-defaults",
      "package": "@nx/react",
      "name": "add-mf-env-var-to-target-defaults"
    },
    {
      "cli": "nx",
      "version": "21.0.0-beta.11",
      "description": "Replaces `classProperties.loose` option with `loose`.",
      "factory": "./src/migrations/update-21-0-0/update-babel-loose",
      "package": "@nx/react",
      "name": "update-21-0-0-update-babel-loose"
    }
  ]
}

```

</details>

---------

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Author: BioPhoton

.gitignore

@@ -51,3 +51,8 @@ Thumbs.db
 
 # Nx workspace cache
 .nx
+
+vite.config.*.timestamp*
+vitest.config.*.timestamp*
+.cursor/rules/nx-rules.mdc
+.github/instructions/nx.instructions.md

e2e/nx-plugin-e2e/tests/inline-plugin.ts renamed to e2e/nx-plugin-e2e/mocks/inline-plugin.ts

@@ -18,7 +18,7 @@ import {
   teardownTestFolder,
 } from '@code-pushup/test-utils';
 import { executeProcess, readJsonFile } from '@code-pushup/utils';
-import { INLINE_PLUGIN } from './inline-plugin.js';
+import { INLINE_PLUGIN } from '../mocks/inline-plugin.js';
 
 async function addTargetToWorkspace(
   tree: Tree,

e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts

@@ -17,7 +17,7 @@ import {
   teardownTestFolder,
 } from '@code-pushup/test-utils';
 import { executeProcess, readTextFile } from '@code-pushup/utils';
-import { INLINE_PLUGIN } from './inline-plugin.js';
+import { INLINE_PLUGIN } from '../mocks/inline-plugin.js';
 
 describe('nx-plugin', () => {
   let tree: Tree;

e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts

@@ -58,6 +58,26 @@ exports[`PLUGIN collect report with typescript-plugin NPM package > should run p
           "description": "Errors that occur during type checking and type inference",
           "details": {
             "issues": [
+              {
+                "message": "TS2694: Namespace ''./index'' has no exported member 'IOptions'.",
+                "severity": "error",
+                "source": {
+                  "file": "node_modules/@types/glob/index.d.ts",
+                  "position": {
+                    "startLine": 29,
+                  },
+                },
+              },
+              {
+                "message": "TS2724: ''./index'' has no exported member named 'IMinimatch'. Did you mean 'Minimatch'?",
+                "severity": "error",
+                "source": {
+                  "file": "node_modules/@types/glob/index.d.ts",
+                  "position": {
+                    "startLine": 74,
+                  },
+                },
+              },
               {
                 "message": "TS2683: 'this' implicitly has type 'any' because it does not have a type annotation.",
                 "severity": "error",
@@ -80,11 +100,11 @@ exports[`PLUGIN collect report with typescript-plugin NPM package > should run p
               },
             ],
           },
-          "displayValue": "2 errors",
+          "displayValue": "4 errors",
           "score": 0,
           "slug": "semantic-errors",
           "title": "Semantic errors",
-          "value": 2,
+          "value": 4,
         },
         {
           "description": "Errors that occur during TypeScript language service operations",

e2e/plugin-typescript-e2e/tests/__snapshots__/collect.e2e.test.ts.snap

@@ -43,7 +43,8 @@
     "e2e": { "dependsOn": ["^build"] },
     "lint": {
       "inputs": ["default", "{workspaceRoot}/eslint.config.?(c)js"],
-      "executor": "@nx/linter:eslint",
+      "executor": "@nx/eslint:lint",
+      "outputs": ["{options.outputFile}"],
       "cache": true,
       "options": {
         "errorOnUnmatchedPattern": false,
@@ -141,7 +142,8 @@
     },
     "version": {
       "conventionalCommits": true,
-      "generatorOptions": {
+      "preserveLocalDependencyProtocols": false,
+      "versionActionsOptions": {
         "skipLockFileUpdate": true
       }
     },