fix(plugin-js-packages-e2e): npm outdated fallback to "wanted" if "current" is missing

happens when package not installed

Author: vmasek

packages/plugin-js-packages/src/lib/package-managers/npm/outdated-result.ts

@@ -1,21 +1,16 @@
 import { objectToEntries } from '@code-pushup/utils';
 import type { OutdatedResult } from '../../runner/outdated/types.js';
-import type { NpmNormalizedOverview, NpmOutdatedResultJson } from './types.js';
+import type { NpmOutdatedResultJson } from './types.js';
 
 export function npmToOutdatedResult(output: string): OutdatedResult {
   const npmOutdated = JSON.parse(output) as NpmOutdatedResultJson;
-  // current might be missing in some cases
+  // "current" might be missing in some cases, usually it is missing if the dependency is not installed, fallback to "wanted" should avoid this problem
   // https://stackoverflow.com/questions/42267101/npm-outdated-command-shows-missing-in-current-version
-  return objectToEntries(npmOutdated)
-    .filter(
-      (entry): entry is [string, NpmNormalizedOverview] =>
-        entry[1].current != null,
-    )
-    .map(([name, overview]) => ({
-      name,
-      current: overview.current,
-      latest: overview.latest,
-      type: overview.type,
-      ...(overview.homepage != null && { url: overview.homepage }),
-    }));
+  return objectToEntries(npmOutdated).map(([name, overview]) => ({
+    name,
+    current: overview.current || overview.wanted,
+    latest: overview.latest,
+    type: overview.type,
+    ...(overview.homepage != null && { url: overview.homepage }),
+  }));
 }

packages/plugin-js-packages/src/lib/package-managers/npm/outdated-result.unit.test.ts

@@ -39,7 +39,7 @@ describe('npmToOutdatedResult', () => {
     ]);
   });
 
-  it('should skip dependencies without current version', () => {
+  it('should not skip dependencies without current version', () => {
     expect(
       npmToOutdatedResult(
         JSON.stringify({
@@ -50,7 +50,14 @@ describe('npmToOutdatedResult', () => {
           },
         }),
       ),
-    ).toEqual([]);
+    ).toEqual([
+      {
+        current: undefined,
+        latest: '5.3.0',
+        name: 'typescript',
+        type: 'dependencies',
+      },
+    ]);
   });
 
   it('should transform no dependencies to empty array', () => {

packages/plugin-js-packages/src/lib/package-managers/npm/types.ts

@@ -36,13 +36,10 @@ export type NpmAuditResultJson = {
 // Subset of NPM outdated JSON type
 export type NpmVersionOverview = {
   current?: string;
+  wanted: string;
   latest: string;
   type: DependencyGroupLong;
   homepage?: string;
 };
 
-export type NpmNormalizedOverview = Omit<NpmVersionOverview, 'current'> & {
-  current: string;
-};
-
 export type NpmOutdatedResultJson = Record<string, NpmVersionOverview>;