fix: several issues of stepByStep report (#4331)

* fix: screenshots to default output even the custom folder is set

* fix: records.html is still created with no screenshots

* fix: error when test failed at beforeSuite

Author: kobenguyent

lib/plugin/stepByStepReport.js

@@ -112,11 +112,13 @@ module.exports = function (config) {
   });
 
   event.dispatcher.on(event.test.failed, (test, err) => {
+    // BeforeSuite/AfterSuite don't have any access to the browser, hence it could not take screenshot.
+    if (test.ctx._runnable.title.includes('hook: BeforeSuite')) return;
     persist(test, err);
   });
 
   event.dispatcher.on(event.all.result, () => {
-    if (!Object.keys(slides).length) return;
+    if (Object.keys(recordedTests).length === 0 || !Object.keys(slides).length) return;
 
     let links = '';
 
@@ -148,7 +150,7 @@ module.exports = function (config) {
     stepNum++;
     slides[fileName] = step;
     try {
-      await helper.saveScreenshot(path.relative(reportDir, path.join(dir, fileName)), config.fullPageScreenshots);
+      await helper.saveScreenshot(path.join(dir, fileName), config.fullPageScreenshots);
     } catch (err) {
       output.plugin(`Can't save step screenshot: ${err}`);
       error = err;

lib/utils.js

@@ -291,7 +291,7 @@ module.exports.screenshotOutputFolder = function (fileName) {
   const fileSep = path.sep;
 
   if (!fileName.includes(fileSep) || fileName.includes('record_')) {
-    return path.join(global.output_dir, fileName);
+    return path.resolve(global.output_dir, fileName);
   }
   return path.resolve(global.codecept_dir, fileName);
 };