Skip to content

Commit 20affd2

Browse files
committed
fix(types): add non-null assertion to lastActivityAt access
Remove TypeScript expect errors by asserting non-null values when accessing the last element with `.at(-1)!`. This ensures type safety and avoids suppressing errors related to potential undefined values in repository arrays sorted by last activity date.
1 parent c5009ac commit 20affd2

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

app/controllers/catalog.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,10 @@ export default class CatalogController extends Controller {
3636
const repositoriesForCourse2 = this.authenticator.currentUser!.repositories.filterBy('course', course2).filterBy('lastActivityAt');
3737

3838
const lastActivityForCourse1At =
39-
// @ts-expect-error at(-1) is not defined on Array
40-
repositoriesForCourse1.length > 0 ? repositoriesForCourse1.sortBy('lastActivityAt').at(-1).lastActivityAt.getTime() : null;
39+
repositoriesForCourse1.length > 0 ? repositoriesForCourse1.sortBy('lastActivityAt').at(-1)!.lastActivityAt.getTime() : null;
4140

4241
const lastActivityForCourse2At =
43-
// @ts-expect-error at(-1) is not defined on Array
44-
repositoriesForCourse2.length > 0 ? repositoriesForCourse2.sortBy('lastActivityAt').at(-1).lastActivityAt.getTime() : null;
42+
repositoriesForCourse2.length > 0 ? repositoriesForCourse2.sortBy('lastActivityAt').at(-1)!.lastActivityAt.getTime() : null;
4543

4644
if (lastActivityForCourse1At && lastActivityForCourse2At && lastActivityForCourse1At > lastActivityForCourse2At) {
4745
return -1;

0 commit comments

Comments
 (0)