Merge pull request #3155 from codecrafters-io/refactor-tutorial-card-remove-step

refactor(tutorial-card): remove read-instructions step and simplify completion logic

Author: rohitpaulk

app/components/course-page/course-stage-step/second-stage-tutorial-card/implement-solution-step.hbs

@@ -1,4 +1,10 @@
 <div class="prose dark:prose-invert prose-compact mb-3">
+  <p>
+    The
+    <a href="#your-task-card">Your Task</a>
+    card below contains a description of what you need to implement to pass tests.
+  </p>
+
   <p>
     Head over to your editor / IDE and implement your solution.
   </p>

app/components/course-page/course-stage-step/second-stage-tutorial-card/index.ts

@@ -66,14 +66,6 @@ export default class SecondStageTutorialCard extends Component<Signature> {
     return this.coursePageState.manuallyCompletedStepIdsInSecondStageInstructions.includes('implement-solution');
   }
 
-  get readInstructionsStepIsComplete() {
-    return this.implementSolutionStepIsComplete || this.readInstructionsStepWasMarkedAsComplete;
-  }
-
-  get readInstructionsStepWasMarkedAsComplete() {
-    return this.coursePageState.manuallyCompletedStepIdsInSecondStageInstructions.includes('read-instructions');
-  }
-
   get runTestsStepIsComplete() {
     return (
       this.args.repository.stageIsComplete(this.args.courseStage) ||
@@ -92,18 +84,7 @@ export default class SecondStageTutorialCard extends Component<Signature> {
 
   @action
   handleStepCompletedManually(step: StepDefinition) {
-    if (step.id === 'read-instructions') {
-      this.coursePageState.recordManuallyCompletedStepInSecondStageInstructions('read-instructions');
-
-      this.analyticsEventTracker.track('completed_second_stage_tutorial_step', {
-        step_number: 1,
-        step_id: 'read-instructions',
-        repository_id: this.args.repository.id,
-      });
-    }
-
     if (step.id === 'implement-solution') {
-      this.coursePageState.recordManuallyCompletedStepInSecondStageInstructions('read-instructions');
       this.coursePageState.recordManuallyCompletedStepInSecondStageInstructions('implement-solution');
 
       this.analyticsEventTracker.track('completed_second_stage_tutorial_step', {