Loosen version, clean up config

Author: MGatner

README.md

@@ -130,6 +130,9 @@ predefined rulesets. Rector can be highly opinionated based on its configuration
 so be sure to read the documentation and figure out the best fit for you. This workflow performs
 a "dry run" to check for any changes that Rector would have made and fail if there are matches.
 
+> Note: Rector updates rules all the time so you may want to lock your repo to the latest known working version of Rector to prevent unexpected failures
+> E.g. in **.github/workflows/rector.yml** supply the specific minor patch: `composer global require --dev rector/rector:0.12.4`
+
 #### Unused
 
 Composer Unused does one thing: checks that your code actually uses the dependencies you

src/.github/workflows/rector.yml

@@ -64,5 +64,5 @@ jobs:
 
       - name: Analyze for refactoring
         run: |
-          composer global require --dev rector/rector:^0.12.4
+          composer global require --dev rector/rector
           rector process --dry-run --no-progress-bar

src/rector.php

@@ -27,69 +27,62 @@
 use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
 use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
-use Rector\Php70\Rector\FuncCall\RandomFunctionRector;
-use Rector\Php71\Rector\FuncCall\CountOnNullRector;
 use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
 use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
-use Rector\PHPUnit\Rector\MethodCall\AssertFalseStrposToContainsRector;
 use Rector\PHPUnit\Set\PHPUnitSetList;
 use Rector\Set\ValueObject\LevelSetList;
 use Rector\Set\ValueObject\SetList;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
 return static function (ContainerConfigurator $containerConfigurator): void {
+    // Rule sets to apply
     $containerConfigurator->import(SetList::DEAD_CODE);
     $containerConfigurator->import(LevelSetList::UP_TO_PHP_73);
     $containerConfigurator->import(PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD);
     $containerConfigurator->import(PHPUnitSetList::PHPUNIT_80);
 
     $parameters = $containerConfigurator->parameters();
 
-    // paths to refactor; solid alternative to CLI arguments
-    $parameters->set(Option::PATHS, [__DIR__ . '/app', __DIR__ . '/tests']);
+    // The paths to refactor (can also be supplied with CLI arguments)
+    $parameters->set(Option::PATHS, [
+        __DIR__ . '/app',
+        __DIR__ . '/tests',
+    ]);
 
-    // do you need to include constants, class aliases or custom autoloader? files listed will be executed
+    // Do you need to include constants, class aliases, or a custom autoloader?
     $parameters->set(Option::BOOTSTRAP_FILES, [
-        realpath(getcwd()) . '/vendor/autoload.php',
         realpath(getcwd()) . '/vendor/codeigniter4/framework/system/Test/bootstrap.php',
     ]);
 
-    // is there a file you need to skip?
+    // Set the target version for refactoring
+    $parameters->set(Option::PHP_VERSION_FEATURES, PhpVersion::PHP_73);
+
+    // Auto-import fully qualified class names
+    $parameters->set(Option::AUTO_IMPORT_NAMES, true);
+
+    // Are there files or rules you need to skip?
     $parameters->set(Option::SKIP, [
         __DIR__ . '/app/Views',
 
         JsonThrowOnErrorRector::class,
         StringifyStrNeedlesRector::class,
 
-        // requires php 8
+        // Note: requires php 8
         RemoveUnusedPromotedPropertyRector::class,
 
-        // call on purpose for nothing happen check
+        // Ignore tests that might make calls without a result
         RemoveEmptyMethodCallRector::class => [
             __DIR__ . '/tests',
         ],
 
-        // may cause load view files directly when detecting class that
-        // make warning
+        // May load view files directly when detecting classes
         StringClassNameToClassConstantRector::class,
 
-        // sometime too detail
-        CountOnNullRector::class,
-
-        // may not be unitialized on purpose
+        // May be uninitialized on purpose
         AddDefaultValueForUndefinedVariableRector::class,
-
-        // use mt_rand instead of random_int on purpose on non-cryptographically random
-        RandomFunctionRector::class,
-
-        // assertContains() to string can't be used in PHPUnit 9.1
-        AssertFalseStrposToContainsRector::class,
     ]);
 
-    // auto import fully qualified class names
-    $parameters->set(Option::AUTO_IMPORT_NAMES, true);
-    $parameters->set(Option::PHP_VERSION_FEATURES, PhpVersion::PHP_73);
-
+    // Additional rules to apply
     $services = $containerConfigurator->services();
     $services->set(SimplifyUselessVariableRector::class);
     $services->set(RemoveAlwaysElseRector::class);