feat: add more prominent failure notice on slogtest error (#190)

* feat: add more prominent failure notice on slogtest error

Signed-off-by: Spike Curtis <spike@coder.com>

* reinstated Fatal logs calling tb.Fatal

Signed-off-by: Spike Curtis <spike@coder.com>

---------

Signed-off-by: Spike Curtis <spike@coder.com>

Author: spikecurtis

sloggers/slogtest/t.go

@@ -7,6 +7,7 @@ package slogtest // import "cdr.dev/slog/sloggers/slogtest"
 
 import (
 	"context"
+	"fmt"
 	"log"
 	"os"
 	"strings"
@@ -78,19 +79,22 @@ func (ts *testSink) LogEntry(ctx context.Context, ent slog.SinkEntry) {
 	// The testing package logs to stdout and not stderr.
 	entryhuman.Fmt(&sb, os.Stdout, ent)
 
-	s := sb.String()
-
 	switch ent.Level {
 	case slog.LevelDebug, slog.LevelInfo, slog.LevelWarn:
-		ts.tb.Log(s)
+		ts.tb.Log(sb.String())
 	case slog.LevelError, slog.LevelCritical:
 		if ts.opts.IgnoreErrors {
-			ts.tb.Log(s)
+			ts.tb.Log(sb.String())
 		} else {
-			ts.tb.Error(s)
+			sb.WriteString(fmt.Sprintf(
+				"\n *** slogtest: log detected at level %s; TEST FAILURE ***",
+				ent.Level,
+			))
+			ts.tb.Error(sb.String())
 		}
 	case slog.LevelFatal:
-		ts.tb.Fatal(s)
+		sb.WriteString("\n *** slogtest: FATAL log detected; TEST FAILURE ***")
+		ts.tb.Fatal(sb.String())
 	}
 }
 

sloggers/slogtest/t_test.go

@@ -55,7 +55,7 @@ func TestCleanup(t *testing.T) {
 		fn()
 	}
 
-	// This shoud not log since the logger was cleaned up.
+	// This should not log since the logger was cleaned up.
 	l.Info(bg, "hello")
 	assert.Equal(t, "no logs", 0, tb.logs)
 }