Skip to content

Commit 7ba4575

Browse files
committed
DEVX-640: refactoring resolveKey and fixing empty set attribute
1 parent 406f0b9 commit 7ba4575

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

commercetools/commercetools-importapi-utils/src/main/java/com/commercetools/sdk/ProductUtil.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,7 @@
3535
import io.vrap.rmf.base.client.Builder;
3636

3737
public final class ProductUtil {
38-
private static KeyResolverService keyResolverService;
39-
40-
public ProductUtil() {
41-
keyResolverService = new ExpandObjResolverService();
42-
}
38+
private static KeyResolverService keyResolverService= new ExpandObjResolverService();
4339

4440
public static ProductDraftImport toProductDraftImport(ProductProjection product) {
4541
var draft = ProductDraftImport.builder()
@@ -229,7 +225,7 @@ private static Attribute mapAttribute(com.commercetools.api.models.product.Attri
229225
if (value instanceof ArrayList) {
230226
var list = (ArrayList<?>) value;
231227
if (list.isEmpty()) {
232-
return Attribute.referenceSetBuilder().build();
228+
return Attribute.textSetBuilder().value().build();
233229
}
234230
if (list.get(0) instanceof LocalDate) {
235231
return Attribute.dateSetBuilder().name(attribute.getName()).value((ArrayList<LocalDate>) list).build();

commercetools/commercetools-importapi-utils/src/test/java/com/commercetools/sdk/ProductUtilTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ void productTransformTestAttributesEmptySet() {
188188
var transformedProduct = toProductDraftImport(testProduct);
189189
assertEquals(testProduct.getKey(), transformedProduct.getKey());
190190
assertEquals(1, transformedProduct.getAttributes().size());
191-
assertEquals("reference", transformedProduct.getAttributes().get(0).getType());
191+
assertEquals("text-set", transformedProduct.getAttributes().get(0).getType());
192192
}
193193

194194
@Test

0 commit comments

Comments
 (0)