feat(migrate): replace lodash.without

Author: phofmann

packages/sync-actions/package.json

@@ -28,8 +28,7 @@
     "lodash.intersection": "^4.4.0",
     "lodash.shuffle": "^4.2.0",
     "lodash.sortby": "^4.7.0",
-    "lodash.uniqwith": "^4.5.0",
-    "lodash.without": "^4.4.0"
+    "lodash.uniqwith": "^4.5.0"
   },
   "files": ["dist", "CHANGELOG.md"],
   "author": "Nicola Molinari <nicola.molinari@commercetools.com> (https://github.com/emmenko)",

packages/sync-actions/src/product-actions.ts

@@ -2,7 +2,6 @@
 import { ProductVariant } from '@commercetools/platform-sdk/src'
 import intersection from 'lodash.intersection'
 import uniqWith from 'lodash.uniqwith'
-import without from 'lodash.without'
 import actionsMapCustom from './utils/action-map-custom'
 import {
   buildBaseAttributesActions,
@@ -425,7 +424,9 @@ function _buildVariantChangeAssetOrderAction(
     .map((_) => _.id)
     .filter((_) => _ !== undefined)
   const assetIdsToKeep = intersection(assetIdsCurrent, assetIdsBefore)
-  const assetIdsToRemove = without(assetIdsBefore, ...assetIdsToKeep)
+  const assetIdsToRemove = assetIdsBefore.filter(
+    (item) => !assetIdsToKeep.includes(item)
+  )
   const changeAssetOrderAction = {
     action: 'changeAssetOrder',
     assetOrder: assetIdsToKeep.concat(assetIdsToRemove),

yarn.lock

@@ -6946,11 +6946,6 @@ lodash.upperfirst@^4.3.1:
   resolved "https://registry.yarnpkg.com/lodash.upperfirst/-/lodash.upperfirst-4.3.1.tgz#1365edf431480481ef0d1c68957a5ed99d49f7ce"
   integrity sha512-sReKOYJIJf74dhJONhU4e0/shzi1trVbSWDOhKYE5XV2O+H7Sb2Dihwuc7xWxVl+DgFPyTqIN3zMfT9cq5iWDg==
 
-lodash.without@^4.4.0:
-  version "4.4.0"
-  resolved "https://registry.yarnpkg.com/lodash.without/-/lodash.without-4.4.0.tgz#3cd4574a00b67bae373a94b748772640507b7aac"
-  integrity sha512-M3MefBwfDhgKgINVuBJCO1YR3+gf6s9HNJsIiZ/Ru77Ws6uTb9eBuvrkpzO+9iLoAaRodGuq7tyrPCx+74QYGQ==
-
 lodash@4.17.21, lodash@^4.17.13, lodash@^4.17.15:
   version "4.17.21"
   resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c"