feat(migrate): adding types to create-map-action-group.ts

Author: phofmann

packages/sync-actions/src/utils/create-map-action-group.ts

@@ -5,17 +5,21 @@
 //   { type: 'prices', group: 'allow' },
 //   { type: 'variants', group: 'ignore' },
 // ]
-export default function createMapActionGroup(actionGroups = []) {
-  return function mapActionGroup(type, fn) {
+import { ActionGroup } from '@commercetools/sdk-client-v2'
+
+export default function createMapActionGroup(
+  actionGroups: Array<ActionGroup> = []
+) {
+  return function mapActionGroup(type: string, fn: () => any) {
     if (!Object.keys(actionGroups).length) return fn()
 
     const found = actionGroups.find((c) => c.type === type)
     if (!found) return []
 
     // Keep `black` for backwards compatibility.
-    if (found.group === 'ignore' || found.group === 'black') return []
+    if (found.group === 'ignore' || (found as any).group === 'black') return []
     // Keep `white` for backwards compatibility.
-    if (found.group === 'allow' || found.group === 'white') return fn()
+    if (found.group === 'allow' || (found as any).group === 'white') return fn()
 
     throw new Error(
       `Action group '${found.group}' not supported. Use either "allow" or "ignore".`

packages/sync-actions/test/utils/create-map-action-group.spec.ts

@@ -1,4 +1,5 @@
 import createMapActionGroup from '../../src/utils/create-map-action-group'
+import { ActionGroup } from '@commercetools/sdk-client-v2'
 
 describe('createMapActionGroup', () => {
   describe('without actionGroups', () => {
@@ -18,7 +19,9 @@ describe('createMapActionGroup', () => {
   describe('with found `actionGroup` (type)', () => {
     describe('with `group` being `allow`', () => {
       const fn = jest.fn()
-      const actionGroups = [{ type: 'base', group: 'allow' }]
+      const actionGroups: Array<ActionGroup> = [
+        { type: 'base', group: 'allow' },
+      ]
       let mapActionGroup
 
       beforeEach(() => {
@@ -33,7 +36,9 @@ describe('createMapActionGroup', () => {
 
     describe('with `group` being `ignore`', () => {
       const fn = jest.fn()
-      const actionGroups = [{ type: 'base', group: 'ignore' }]
+      const actionGroups: Array<ActionGroup> = [
+        { type: 'base', group: 'ignore' },
+      ]
       let mapActionGroup
 
       beforeEach(() => {
@@ -52,7 +57,9 @@ describe('createMapActionGroup', () => {
       let mapActionGroup
 
       beforeEach(() => {
-        mapActionGroup = createMapActionGroup(actionGroups)
+        mapActionGroup = createMapActionGroup(
+          actionGroups as Array<ActionGroup>
+        )
       })
 
       test('should throw an error', () => {
@@ -74,7 +81,7 @@ describe('createMapActionGroup', () => {
 
   describe('with non found `actionGroup` (type)', () => {
     const fn = jest.fn()
-    const actionGroups = [{ type: 'base', group: 'allow' }]
+    const actionGroups: Array<ActionGroup> = [{ type: 'base', group: 'allow' }]
     let mapActionGroup
 
     beforeEach(() => {