feat(migrate): replace lodash.sortby

Author: phofmann

packages/sync-actions/package.json

@@ -24,8 +24,7 @@
   },
   "dependencies": {
     "fast-equals": "^2.0.0",
-    "jsondiffpatch": "^0.4.0",
-    "lodash.sortby": "^4.7.0"
+    "jsondiffpatch": "^0.4.0"
   },
   "files": ["dist", "CHANGELOG.md"],
   "author": "Nicola Molinari <nicola.molinari@commercetools.com> (https://github.com/emmenko)",

packages/sync-actions/src/types-actions.ts

@@ -1,5 +1,4 @@
 import { deepEqual } from 'fast-equals'
-import sortBy from 'lodash.sortby'
 import { buildBaseAttributesActions } from './utils/common-actions'
 import createBuildArrayActions, {
   ADD_ACTIONS,
@@ -202,10 +201,18 @@ export function actionsMapFieldDefinitions(
   // in order to prevent any eventual removal of `addAction`.
   // List of `removeActions` can be found here
   // https://docs.commercetools.com/http-api-projects-types.html#change-key
-  const sortedActions = sortBy(
-    actions,
-    (action) => action.action !== 'removeFieldDefinition'
-  )
 
-  return sortedActions
+  return actions.sort((a, b) => {
+    if (
+      a.action === 'removeFieldDefinition' &&
+      a.action === 'removeFieldDefinition'
+    ) {
+      return (a.fieldName as string).localeCompare(b.fieldName)
+    } else if (a.action === 'removeFieldDefinition') {
+      return -1
+    } else if (b.action === 'removeFieldDefinition') {
+      return -1
+    }
+    return 0
+  })
 }

yarn.lock

@@ -6911,11 +6911,6 @@ lodash.snakecase@^4.1.1:
   resolved "https://registry.yarnpkg.com/lodash.snakecase/-/lodash.snakecase-4.1.1.tgz#39d714a35357147837aefd64b5dcbb16becd8f8d"
   integrity sha512-QZ1d4xoBHYUeuouhEq3lk3Uq7ldgyFXGBhg04+oRLnIz8o9T65Eh+8YdroUwn846zchkA9yDsDl5CVVaV2nqYw==
 
-lodash.sortby@^4.7.0:
-  version "4.7.0"
-  resolved "https://registry.yarnpkg.com/lodash.sortby/-/lodash.sortby-4.7.0.tgz#edd14c824e2cc9c1e0b0a1b42bb5210516a42438"
-  integrity sha512-HDWXG8isMntAyRF5vZ7xKuEvOhT4AhlRt/3czTSjvGUxjYCBVRQY48ViDHyfYz9VIoBkW4TMGQNapx+l3RUwdA==
-
 lodash.startcase@^4.4.0:
   version "4.4.0"
   resolved "https://registry.yarnpkg.com/lodash.startcase/-/lodash.startcase-4.4.0.tgz#9436e34ed26093ed7ffae1936144350915d9add8"