Skip to content

Fix: Bottom buttons overlapping navigation bar in Edit Image screen (#6495) #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+1 −0
Open

Fix: Bottom buttons overlapping navigation bar in Edit Image screen (#6495) #6541

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
babc06d
Fix bottom buttons overlapping navigation bar in Edit Image screen (#…
JiaxinLi1122 Oct 25, 2025
c677ece
Fix bottom buttons overlapping navigation bar in Edit Image screen (#…
JiaxinLi1122 Oct 25, 2025
22e5ae5
Revert "Fix bottom buttons overlapping navigation bar in Edit Image s…
JiaxinLi1122 Oct 25, 2025
0af7431
Merge branch 'main' into fix-6495-bottom-buttons
nicolas-raoul Oct 25, 2025
72c2566
remove paddingBottom
JiaxinLi1122 Oct 25, 2025
943e857
Merge remote-tracking branch 'origin/fix-6495-bottom-buttons' into fi…
JiaxinLi1122 Oct 25, 2025
7d6ad40
Merge branch 'main' into fix-6495-bottom-buttons
RitikaPahwa4444 Oct 26, 2025
07fb4ba
Merge branch 'main' into fix-6495-bottom-buttons
nicolas-raoul Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/src/main/res/layout/activity_edit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_gravity="bottom"
android:fitsSystemWindows="true"
tools:context=".edit.EditActivity"
android:gravity="center"
android:layout_margin="2dp"
Expand All @@ -22,7 +23,8 @@
android:layout_gravity="bottom|center"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_margin="2dp">
android:layout_margin="2dp"
android:paddingBottom="24dp">
Copy link
Member

@nicolas-raoul nicolas-raoul Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this paddingBottom really needed? Would you mind posting a screenshot showing how the screen looks like when the OS is configured to not show the navigation buttons?

Thanks a lot for contributing! :-)

Copy link
Author

@JiaxinLi1122 JiaxinLi1122 Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is Samsung Galaxy S23 (Android 15, API 35) without navigation buttons:image

Copy link
Author

@JiaxinLi1122 JiaxinLi1122 Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the extra padding can be removed — it was mostly for visual spacing, to make the buttons look less close to the navigation bar.

Copy link
Member

@nicolas-raoul nicolas-raoul Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood! Better remove it I guess, so that the space can be used on small screens or in landscape mode.

Copy link
Author

@JiaxinLi1122 JiaxinLi1122 Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!


<androidx.appcompat.widget.AppCompatButton
android:drawablePadding="4dp"
Expand Down