Updated configuration to set None as default domain (#351)

Author: IgorChvyrov-sm

src/conductor/asyncio_client/configuration/configuration.py

@@ -154,7 +154,7 @@ def __init__(
         self.polling_interval = polling_interval or self._get_env_int(
             "CONDUCTOR_WORKER_POLL_INTERVAL", 100
         )
-        self.domain = domain or os.getenv("CONDUCTOR_WORKER_DOMAIN", "default_domain")
+        self.domain = domain or os.getenv("CONDUCTOR_WORKER_DOMAIN", None)
         self.polling_interval_seconds = polling_interval_seconds or self._get_env_int(
             "CONDUCTOR_WORKER_POLL_INTERVAL_SECONDS", 0
         )

src/conductor/client/configuration/configuration.py

@@ -193,7 +193,7 @@ def __init__(
         self.polling_interval = polling_interval or self._get_env_float(
             "CONDUCTOR_WORKER_POLL_INTERVAL", 100
         )
-        self.domain = domain or os.getenv("CONDUCTOR_WORKER_DOMAIN", "default_domain")
+        self.domain = domain or os.getenv("CONDUCTOR_WORKER_DOMAIN", None)
         self.polling_interval_seconds = polling_interval_seconds or self._get_env_float(
             "CONDUCTOR_WORKER_POLL_INTERVAL_SECONDS", 0
         )

tests/unit/asyncio_client/test_configuration.py

@@ -10,7 +10,7 @@ def test_initialization_default():
     config = Configuration()
     assert config.server_url is not None
     assert config.polling_interval == 100
-    assert config.domain == "default_domain"
+    assert config.domain is None
     assert config.polling_interval_seconds == 0
     assert config.debug is False
 
@@ -138,7 +138,7 @@ def test_get_worker_property_value_default():
 def test_get_worker_property_value_domain():
     config = Configuration()
     result = config.get_worker_property_value("domain", "mytask")
-    assert result == "default_domain"
+    assert result is None
 
 
 def test_get_worker_property_value_poll_interval_seconds():
@@ -226,7 +226,7 @@ def test_get_domain_with_task_type(monkeypatch):
 def test_get_domain_default():
     config = Configuration()
     result = config.get_domain("mytask")
-    assert result == "default_domain"
+    assert result is None
 
 
 def test_get_poll_interval_with_task_type(monkeypatch):

tests/unit/worker/test_sync_worker.py

@@ -97,8 +97,7 @@ def test_init_with_defaults(simple_execute_function):
 
     assert worker.task_definition_name == "test_task"
     assert worker.poll_interval == 100
-    assert worker.domain is not None
-    assert worker.domain == "default_domain"
+    assert worker.domain is None
     assert worker.worker_id is not None
     assert worker.execute_function == simple_execute_function
 

tests/unit/worker/test_worker.py

@@ -89,7 +89,7 @@ def test_init_with_defaults(simple_execute_function):
 
     assert worker.task_definition_name == "test_task"
     assert worker.poll_interval == 100
-    assert worker.domain == "default_domain"
+    assert worker.domain is None
     assert worker.worker_id is not None
     assert worker.execute_function == simple_execute_function