Clone any object used in search criteria.

Without cloning, objects with array access end up being modified.

Author: judgej

src/HasModelDataTrait.php

@@ -45,6 +45,11 @@ public function get(string $key, $default = null)
         return data_get($this->data, $key, $default);
     }
 
+    public function __get($name)
+    {
+        return $this->get($name);
+    }
+
     public function jsonSerialize()
     {
         return $this->data;

src/OdooClient.php

@@ -265,7 +265,7 @@ public function nullValue()
      * @param int $offset
      * @param int $limit
      * @param string $order comma-separated list of fields
-     * @return Response
+     * @return mixed
      */
     public function search(
         string $modelName,
@@ -917,6 +917,16 @@ public function nativeToValue($item)
 
         // If an iterable, then deal with the children first.
 
+        // Clone the item if it is an object.
+        // If we don't, then collections get changed in-situ, i.e. your
+        // collection of IDs submitted for the criteria is converted to
+        // XML-RPC Value objects.
+        // Arrays are automatically cloned by PHP on first change.
+
+        if (is_object($item)) {
+            $item = clone($item);
+        }
+
         foreach ($item as $key => $element) {
             $item[$key] = $this->nativeToValue($element);
         }