test(authorization): improved tests to use real MCP clients #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Nuri <marc@marcnuri.com>
matzew
reviewed
Nov 7, 2025
|
|
||
| func McpInitRequest() mcp.InitializeRequest { | ||
| initRequest := mcp.InitializeRequest{} | ||
| initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION |
Collaborator
There was a problem hiding this comment.
just curiois: new sdk requires 2025-06-18 ?
Member
Author
There was a problem hiding this comment.
No, that was already there:
kubernetes-mcp-server/internal/test/mcp.go
Lines 31 to 33 in 6342379
Just moved it around and made it reusable.
Collaborator
|
nice Authorization tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will facilitate #385
After these changes, the entire test suite should pass with go-sdk, any failure is related to a missing implementation.