Added some safety to not play sounds past the limit and removed the assert. Lowered sound per container limit down to 128.

Author: garethyr

Entities/SoundContainer.h

@@ -201,7 +201,7 @@ namespace RTE {
 		/// Adds a channel index to the SoundContainer's collection of playing channels.
 		/// </summary>
 		/// <param name="channel">The channel index to add.</param>
-		void AddPlayingChannel(unsigned short channel) { m_PlayingChannels.insert(channel); RTEAssert(m_PlayingChannels.size() <= c_MaxPlayingSoundsPerContainer, "Tried to play more than " + std::to_string(c_MaxPlayingSoundsPerContainer) + " sounds in SoundContainer " + GetPresetName()); }
+		void AddPlayingChannel(unsigned short channel) { m_PlayingChannels.insert(channel); }
 
 		/// <summary>
 		/// Removes a channel index from the SoundContainer's collection of playing channels.

Managers/AudioMan.cpp

@@ -423,7 +423,7 @@ namespace RTE {
 /////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
 
 	bool AudioMan::PlaySound(SoundContainer *soundContainer, const Vector &position, int player, int priority, double pitch) {
-		if (!m_AudioEnabled || !soundContainer) {
+		if (!m_AudioEnabled || !soundContainer || soundContainer->GetPlayingChannels()->size() >= c_MaxPlayingSoundsPerContainer - 2) {
 			return false;
 		}
 		FMOD_RESULT result = FMOD_OK;

System/Constants.h

@@ -57,7 +57,7 @@ namespace RTE {
 #pragma region Audio Constants
 	static constexpr unsigned short c_MaxSoftwareChannels = 128;
 	static constexpr unsigned short c_MaxVirtualChannels = 1024;
-	static constexpr unsigned short c_MaxPlayingSoundsPerContainer = 256;
+	static constexpr unsigned short c_MaxPlayingSoundsPerContainer = 128;
 	/* TODO These have been temporarily replaced with variables in settingsman to allow for easy tweaking. This needs to be undone once our soundscape is sorted out.
 	static constexpr unsigned short c_ListenerZOffset = 50; //!< The Z offset for Audio listeners. Can be used to lessen harsh panning if panning effect strength is at max.
 	static constexpr unsigned short c_MinimumDistanceForPanning = 50; //!< The minimum distance before which sound panning should not occur. Not relevant for immobile sounds or in splitscreen.