use latest System.CommandLine version (GA?) (#1660)

* Update System.CommandLine nuget package and improve documentation

- Upgraded `System.CommandLine` package version.
- Clarified documentation in `GlobalTool.md` regarding options and exit codes.
- Modified Azure Pipelines YAML for package restoration and authentication.
- Removed `PackageIconUrl` from `coverlet.collector.csproj`.
- Updated `CommandExitCodes` enum in `ExitCodes.cs`.
- Refactored `Program.cs` to utilize the new `System.CommandLine` API.
- Changed command exit code handling to use a static variable.
- Added new package references in `coverlet.console.csproj` and `coverlet.core.csproj`.
- Revised integration tests for expected output and error handling.
- Adjusted coverage output assertions in tests.
- Improved directory handling and file deletion logic in `DeterministicBuild.cs`.
- Added reference to `coverlet.console` in `coverlet.integration.tests.csproj`.

* Refactor Main method to return exit code

Changed Main method's return type to Task<int> to allow returning an exit code. Replaced Environment.Exit with a return statement for better control over the exit code and improved usability in asynchronous contexts. This avoids the termination of the process.

Author: Bertk

.editorconfig

@@ -227,3 +227,4 @@ csharp_style_prefer_top_level_statements = true:silent
 csharp_style_prefer_primary_constructors = true:suggestion
 csharp_style_expression_bodied_lambdas = true:silent
 csharp_style_expression_bodied_local_functions = false:silent
+dotnet_diagnostic.IDE0007.severity = suggestion

.gitignore

@@ -319,3 +319,4 @@ FolderProfile.pubxml
 nuget.config
 *.dmp
 Playground*/
+coverlet.MTP/

Directory.Build.props

@@ -15,7 +15,7 @@
     <CodeAnalysisTreatWarningsAsErrors>false</CodeAnalysisTreatWarningsAsErrors>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <LangVersion>12.0</LangVersion>
-    <NoWarn>$(NoWarn);NU1507;NU5105;CS1591</NoWarn>
+    <NoWarn>$(NoWarn);NU1507;NU5105;CS1591;NU1608;NU1900</NoWarn>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <RestoreSources>
       https://api.nuget.org/v3/index.json;

Directory.Packages.props

@@ -8,11 +8,11 @@
     <GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.7.115" />
   </ItemGroup>
   <PropertyGroup>
-    <MicrosoftBuildVersion>17.13.9</MicrosoftBuildVersion>
+    <MicrosoftBuildVersion>17.11.31</MicrosoftBuildVersion> <!-- .NET 8.0 support -->
     <MicrosoftCodeAnalysisVersion>4.12.0</MicrosoftCodeAnalysisVersion>
     <!-- Test Platform, .NET Test SDK and Object Model  -->
-    <MicrosoftNETTestSdkVersion>17.13.0</MicrosoftNETTestSdkVersion>
-    <NugetPackageVersion>6.13.2</NugetPackageVersion>
+    <MicrosoftNETTestSdkVersion>17.14.1</MicrosoftNETTestSdkVersion>
+    <NugetPackageVersion>6.14.0</NugetPackageVersion>
     <XunitV3Version>2.0.0</XunitV3Version>
     <XunitRunnerVisualstudioVersion>3.0.2</XunitRunnerVisualstudioVersion>
   </PropertyGroup>
@@ -21,7 +21,7 @@
     <PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
     <PackageVersion Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildVersion)" />
     <PackageVersion Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildVersion)" />
-    <PackageVersion Include="Microsoft.Build.Locator" Version="1.7.8" />
+    <PackageVersion Include="Microsoft.Build.Locator" Version="1.9.1" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="$(MicrosoftCodeAnalysisVersion)" />
     <PackageVersion Include="Microsoft.Extensions.DependencyModel" Version="8.0.2" />
     <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="8.0.1" />
@@ -48,7 +48,7 @@
     <PackageVersion Include="ReportGenerator.Core" Version="5.3.11" />
     <!--For test issue 809 https://github.com/coverlet-coverage/coverlet/issues/809-->
     <PackageVersion Include="LinqKit.Microsoft.EntityFrameworkCore" Version="8.1.8" />
-    <PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
+    <PackageVersion Include="System.CommandLine" Version="2.0.0-beta6.25358.103" />
     <!--To test issue 1104 https://github.com/coverlet-coverage/coverlet/issues/1104-->
     <!-- latest Tmds.ExecFunction package uses EnvDTE V17.8.37221 -->
     <PackageVersion Include="Tmds.ExecFunction" Version="0.8.0" />

Documentation/GlobalTool.md

@@ -38,7 +38,7 @@ Options:
   --merge-with <merge-with>                                                  Path to existing coverage result to merge.
   --use-source-link                                                          Specifies whether to use SourceLink URIs in place of file system paths.
   --does-not-return-attribute <does-not-return-attribute>                    Attributes that mark methods that do not return
-  --exclude-assemblies-without-sources <exclude-assemblies-without-sources>  Specifies behaviour of heuristic to ignore assemblies with missing source documents.
+  --exclude-assemblies-without-sources <exclude-assemblies-without-sources>  Specifies behavior of heuristic to ignore assemblies with missing source documents. [default: MissingAll]
   --source-mapping-file <source-mapping-file>                                Specifies the path to a SourceRootsMappings file.
   --version                                                                  Show version information
   -?, -h, --help                                                             Show help and usage information
@@ -275,5 +275,4 @@ Coverlet outputs specific exit codes to better support build automation systems
 2 - Coverage percentage is below threshold.
 3 - Test fails and also coverage percentage is below threshold.
 101 - General exception occurred during coverlet process.
-102 - Missing options or invalid arguments for coverlet process.
 ```

eng/azure-pipelines-nightly.yml

@@ -15,6 +15,9 @@ steps:
 - task: NuGetAuthenticate@1
   displayName: Authenticate with NuGet feeds
 
+- script: dotnet restore
+  displayName: Restore packages
+
 - script: dotnet pack -c Release /p:PublicRelease=false
   displayName: Create NuGet packages
 

eng/build.yml

@@ -15,9 +15,23 @@ steps:
     New-Item -ItemType Directory -Path artifacts/package/release -Force
   displayName: create folder artifacts/package/$(BuildConfiguration)
 
-- script: dotnet restore
+# Authenticate Azure DevOps NuGet feed
+- task: NuGetAuthenticate@1
+  displayName: 'Authenticate Azure DevOps NuGet feed'
+  inputs:
+    forceReinstallCredentialProvider: true
+
+- script: dotnet restore -v n -s "https://api.nuget.org/v3/index.json"
   displayName: Restore packages
 
+# - task: DotNetCoreCLI@2
+#   displayName: Restore packages
+#   inputs:
+#     command: restore
+#     projects: 'coverlet.sln'
+#     feedsToUse: 'config'
+#     nugetConfigPath: 'nuget.config'
+
 - script: dotnet build -c $(BuildConfiguration) --no-restore -bl:build.msbuild.binlog
   displayName: Build
 

src/coverlet.collector/coverlet.collector.csproj

@@ -27,7 +27,6 @@
     <Authors>tonerdo</Authors>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageProjectUrl>https://github.com/coverlet-coverage/coverlet</PackageProjectUrl>
-    <PackageIconUrl>https://raw.githubusercontent.com/tonerdo/coverlet/master/_assets/coverlet-icon.svg?sanitize=true</PackageIconUrl>
     <PackageIcon>coverlet-icon.png</PackageIcon>
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
     <Description>Coverlet is a cross platform code coverage library for .NET, with support for line, branch and method coverage.</Description>

src/coverlet.console/ExitCodes.cs

@@ -29,9 +29,5 @@ internal enum CommandExitCodes
   /// </summary>
   Exception = 101,
 
-  /// <summary>
-  /// Indicates missing options or empty arguments for Coverlet process.
-  /// </summary>
-  CommandParsingException = 102
 }