Used cppcheck to fix a few harmless bugs.

Author: cschreib

gui/src/gui_slider.cpp

@@ -234,7 +234,7 @@ void slider::set_max_value(float fMax)
     if (fMax != fMaxValue_)
     {
         fMaxValue_ = fMax;
-        if (fMaxValue_ < fMaxValue_) fMaxValue_ = fMinValue_;
+        if (fMaxValue_ < fMinValue_) fMaxValue_ = fMinValue_;
         else step_value(fMaxValue_, fValueStep_);
 
         if (fValue_ > fMaxValue_)

gui/src/gui_statusbar.cpp

@@ -124,7 +124,7 @@ void status_bar::set_max_value(float fMax)
     if (fMax != fMaxValue_)
     {
         fMaxValue_ = fMax;
-        if (fMaxValue_ < fMaxValue_) fMaxValue_ = fMinValue_;
+        if (fMaxValue_ < fMinValue_) fMaxValue_ = fMinValue_;
         fValue_ = fValue_ > fMaxValue_ ? fMaxValue_ : (fValue_ < fMinValue_ ? fMinValue_ : fValue_);
         fire_update_bar_texture_();
     }

gui/src/gui_uiobject.cpp

@@ -259,7 +259,8 @@ bool uiobject::is_visible() const
 
 void uiobject::set_abs_dimensions(uint uiAbsWidth, uint uiAbsHeight)
 {
-    if (uiAbsWidth_ != uiAbsWidth || !bIsWidthAbs_ || uiAbsHeight_ != uiAbsHeight || !bIsWidthAbs_)
+    if (uiAbsWidth_  != uiAbsWidth  || !bIsWidthAbs_ ||
+        uiAbsHeight_ != uiAbsHeight || !bIsHeightAbs_)
     {
         pManager_->notify_object_moved();
         bIsWidthAbs_ = true;

luapp/src/luapp_state.cpp

@@ -784,7 +784,6 @@ std::string state::get_type_name(type mType)
 void state::get_global(const std::string& sName)
 {
     std::deque<std::string> lDecomposedName;
-    std::string sVarName;
     utils::string_vector lWords = utils::cut(sName, ":");
     utils::string_vector::iterator iter1;
     foreach (iter1, lWords)