fix: queue ARN might be undefined after plan

Author: Kilian

main.tf

@@ -145,7 +145,7 @@ resource "aws_lambda_function" "main" {
 }
 
 resource "aws_lambda_event_source_mapping" "queue" {
-  count            = try(var.trigger["queue_arn"], null) != null ? 1 : 0
+  count            = var.trigger != null ? 1 : 0
   event_source_arn = var.trigger["queue_arn"]
   enabled          = true
   function_name    = aws_lambda_function.main.arn
@@ -167,13 +167,3 @@ resource "aws_lambda_event_source_mapping" "queue" {
     }
   }
 }
-
-resource "aws_lambda_event_source_mapping" "stream" {
-  count                  = try(var.trigger["stream_arn"], null) != null ? 1 : 0
-  event_source_arn       = var.trigger["stream_arn"]
-  enabled                = true
-  function_name          = aws_lambda_function.main.arn
-  batch_size             = var.trigger["batch_size"]
-  maximum_retry_attempts = var.trigger["max_retries"]
-  starting_position      = "LATEST"
-}

tests/trigger.tftest.hcl

@@ -7,21 +7,7 @@ provider "aws" {
   }
 }
 
-run "queue_and_stream_arn_defined" {
-  command = plan
-
-  variables {
-    identifier = "abc"
-    trigger = {
-      queue_arn  = "test-queue"
-      stream_arn = "test-stream"
-    }
-  }
-
-  expect_failures = [var.trigger]
-}
-
-run "queue_and_stream_arn_undefined" {
+run "trigger_defined_queue_arn_undefined" {
   command = plan
 
   variables {
@@ -32,32 +18,6 @@ run "queue_and_stream_arn_undefined" {
   expect_failures = [var.trigger]
 }
 
-run "filter_without_queue" {
-  command = plan
-
-  variables {
-    identifier = "abc"
-    trigger = {
-      stream_arn = "test-stream"
-      filter     = "test"
-    }
-  }
-
-  expect_failures = [var.trigger]
-}
-
-run "filter_with_queue" {
-  command = plan
-
-  variables {
-    identifier = "abc"
-    trigger = {
-      queue_arn = "test-queue"
-      filter    = "test"
-    }
-  }
-}
-
 run "max_concurrency_upper_limit" {
   command = plan
 
@@ -100,32 +60,6 @@ run "queue_trigger" {
     condition     = length(aws_lambda_event_source_mapping.queue) == 1
     error_message = "Queue source mapping was not created"
   }
-
-  assert {
-    condition     = length(aws_lambda_event_source_mapping.stream) == 0
-    error_message = "Stream source mapping was created unexpectedly"
-  }
-}
-
-run "stream_trigger" {
-  command = plan
-
-  variables {
-    identifier = "abc"
-    trigger = {
-      stream_arn = "test-stream"
-    }
-  }
-
-  assert {
-    condition     = length(aws_lambda_event_source_mapping.queue) == 0
-    error_message = "Queue source mapping was created unexpectedly"
-  }
-
-  assert {
-    condition     = length(aws_lambda_event_source_mapping.stream) == 1
-    error_message = "Stream source mapping was not created"
-  }
 }
 
 run "without_trigger" {
@@ -140,9 +74,4 @@ run "without_trigger" {
     condition     = length(aws_lambda_event_source_mapping.queue) == 0
     error_message = "Queue source mapping was created unexpectedly"
   }
-
-  assert {
-    condition     = length(aws_lambda_event_source_mapping.stream) == 0
-    error_message = "Stream source mapping was created unexpectedly"
-  }
 }

variables.tf

@@ -17,28 +17,16 @@ variable "trigger" {
   description = "Object to define trigger of the Lambda function."
   type = object({
     queue_arn       = optional(string, null)
-    stream_arn      = optional(string, null)
     batch_size      = optional(number, 1)
     max_concurrency = optional(number, 1000)
     max_retries     = optional(number, -1)
     filter          = optional(string, null)
   })
   default = null
   validation {
-    condition = var.trigger == null || (
-    try(var.trigger["queue_arn"], null) != null || try(var.trigger["stream_arn"], null) != null)
+    condition     = var.trigger == null || try(var.trigger["queue_arn"], null) != null
     error_message = "Either 'queue_arn' or 'stream_arn' must be defined"
   }
-  validation {
-    condition = var.trigger == null || (
-    try(var.trigger["queue_arn"], null) == null || try(var.trigger["stream_arn"], null) == null)
-    error_message = "Values 'queue_arn' and 'stream_arn' can not be both defined"
-  }
-  validation {
-    condition = !(
-    try(var.trigger["queue_arn"], null) == null && try(var.trigger["filter"], null) != null)
-    error_message = "Value 'queue_arn' must be defined if 'filter' is defined"
-  }
   validation {
     condition = try(var.trigger["max_concurrency"], 1000) <= 1000 && (
     try(var.trigger["max_concurrency"], 2) >= 2)