docs: Fix comment about platform address size when reading string slice lengths

cxiao · cxiao · commit 6d91d331c589 · 2023-12-24T18:55:24.000-07:00
diff --git a/binja_plugin/actions.py b/binja_plugin/actions.py
@@ -136,7 +136,7 @@ def run(self):
 
             candidate_string_slice_len = self.bv.read_int(
                 address=candidate_string_slice_len_addr,
-                size=self.bv.arch.address_size,  # TODO: is there a better way to get the maximum int size per platform?
+                size=self.bv.arch.address_size,  # In Rust's definition of the `str` type, this length is a `usize`, which is defined to be the same size as the size of pointers for the platform.
                 sign=False,
                 endian=self.bv.arch.endianness,
             )

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ def run(self):`
`136`	`136`
`137`	`137`	`candidate_string_slice_len = self.bv.read_int(`
`138`	`138`	`address=candidate_string_slice_len_addr,`
`139`		`- size=self.bv.arch.address_size, # TODO: is there a better way to get the maximum int size per platform?`
	`139`	+ size=self.bv.arch.address_size, # In Rust's definition of the `str` type, this length is a `usize`, which is defined to be the same size as the size of pointers for the platform.
`140`	`140`	`sign=False,`
`141`	`141`	`endian=self.bv.arch.endianness,`
`142`	`142`	`)`