Skip to content

Commit 019007c

Browse files
committed
change docstring; update return val
1 parent 52b45a2 commit 019007c

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

aws_sra_examples/solutions/genai/bedrock_org/lambda/src/sra_cloudwatch.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -247,21 +247,21 @@ def create_oam_sink(self, sink_name: str) -> str:
247247
self.LOGGER.error(f"{self.UNEXPECTED} error: {e}")
248248
raise ValueError(f"Unexpected error executing Lambda function. {e}") from None
249249

250-
def delete_oam_sink(self, sink_arn: str) -> None:
251-
"""Delete the Observability Access Manager sink for SRA in the organization.
252-
253-
Args:
254-
sink_arn (str): ARN of the sink
255-
256-
Returns:
257-
None
258-
"""
259-
try:
260-
self.CWOAM_CLIENT.delete_sink(Identifier=sink_arn)
261-
self.LOGGER.info(f"Observability access manager sink {sink_arn} deleted")
262-
except ClientError as e:
263-
self.LOGGER.info(self.UNEXPECTED)
264-
raise ValueError(f"Unexpected error executing Lambda function. {e}") from None
250+
# def delete_oam_sink(self, sink_arn: str) -> None:
251+
# """Delete the Observability Access Manager sink for SRA in the organization.
252+
253+
# Args:
254+
# sink_arn (str): ARN of the sink
255+
256+
# Returns:
257+
# None
258+
# """
259+
# try:
260+
# self.CWOAM_CLIENT.delete_sink(Identifier=sink_arn)
261+
# self.LOGGER.info(f"Observability access manager sink {sink_arn} deleted")
262+
# except ClientError as e:
263+
# self.LOGGER.info(self.UNEXPECTED)
264+
# raise ValueError(f"Unexpected error executing Lambda function. {e}") from None
265265

266266
def find_oam_sink_policy(self, sink_arn: str) -> tuple[bool, dict]:
267267
"""Check if the Observability Access Manager sink policy for SRA in the organization exists.

aws_sra_examples/solutions/genai/bedrock_org/lambda/src/sra_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def find_config_rule(self, rule_name):
111111
except ClientError as e:
112112
if e.response["Error"]["Code"] == "NoSuchConfigRuleException":
113113
self.LOGGER.info(f"No such config rule: {rule_name}")
114-
return False, None
114+
return False, {}
115115
else:
116116
self.LOGGER.info(f"Unexpected error: {e}")
117117
raise e

0 commit comments

Comments
 (0)