fixing flake8 issues in ssm params module

Author: cyphronix

aws_sra_examples/solutions/genai/bedrock_org/lambda/src/app.py

@@ -191,7 +191,7 @@ def load_sra_cloudwatch_dashboard() -> dict:
 
 # Instantiate sra class objects
 # TODO(liamschn): can these files exist in some central location to be shared with other solutions?
-ssm_params = sra_ssm_params.sra_ssm_params()
+ssm_params = sra_ssm_params.SRASSMParams()
 iam = sra_iam.SRAIAM()
 dynamodb = sra_dynamodb.SRADynamoDB()
 sts = sra_sts.sra_sts()

aws_sra_examples/solutions/genai/bedrock_org/lambda/src/sra_ssm_params.py

@@ -14,22 +14,23 @@
 import os
 import re
 from time import sleep
-from typing import TYPE_CHECKING, Any, List, Literal, Optional, Sequence, Union, cast
+from typing import TYPE_CHECKING, Any, List, Literal, Optional, Sequence, Union
 
 import boto3
 from botocore.config import Config
 from botocore.exceptions import ClientError, EndpointConnectionError
 
 if TYPE_CHECKING:
-    from aws_lambda_typing.context import Context
     from aws_lambda_typing.events import CloudFormationCustomResourceEvent
     from mypy_boto3_cloudformation import CloudFormationClient
     from mypy_boto3_organizations import OrganizationsClient
     from mypy_boto3_ssm import SSMClient
     from mypy_boto3_ssm.type_defs import TagTypeDef
 
 
-class sra_ssm_params:
+class SRASSMParams:
+    """Class to manage SSM Parameters."""
+
     # Setup Default Logger
     LOGGER = logging.getLogger(__name__)
     log_level: str = os.environ.get("LOG_LEVEL", "INFO")
@@ -60,7 +61,6 @@ class sra_ssm_params:
         "/sra/regions/customer-control-tower-regions-without-home-region",
         "/sra/staging-s3-bucket-name",
     ]
-    # todo(liamschn): in the common prerequisite solution add an sra execution/configuration role parameter
 
     SRA_STAGING_BUCKET: str = ""
     UNEXPECTED = "Unexpected!"
@@ -565,8 +565,7 @@ def get_ssm_parameter(self, session: Any, region: str, parameter: str) -> tuple[
             if e.response["Error"]["Code"] == "ParameterNotFound":
                 self.LOGGER.info(f"SSM parameter '{parameter}' not found.")
                 return False, ""
-            else:
-                self.LOGGER.info(f"Error getting SSM parameter '{parameter}': {e.response['Error']['Message']}")
-                return False, ""
+            self.LOGGER.info(f"Error getting SSM parameter '{parameter}': {e.response['Error']['Message']}")
+            return False, ""
         self.LOGGER.info(f"SSM parameter '{parameter}' found.")
         return True, response["Parameter"]["Value"]