Skip to content

Commit c685d28

Browse files
committed
still updating filter to filter_name
1 parent 3de6457 commit c685d28

File tree

1 file changed

+16
-16
lines changed
  • aws_sra_examples/solutions/genai/bedrock_org/lambda/src

1 file changed

+16
-16
lines changed

aws_sra_examples/solutions/genai/bedrock_org/lambda/src/app.py

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -842,23 +842,23 @@ def deploy_metric_filters_and_alarms(region, accounts, resource_properties):
842842
add_state_table_record("sns", "implemented", "sns topic for alarms", "topic", SRA_ALARM_TOPIC_ARN, acct, region, f"{SOLUTION_NAME}-alarms")
843843

844844
# 4c) Cloudwatch metric filters and alarms
845-
# metric_filter_arn = f"arn:aws:logs:{region}:{acct}:metric-filter:{filter}"
845+
# metric_filter_arn = f"arn:aws:logs:{region}:{acct}:metric-filter:{filter_name}"
846846
if DRY_RUN is False:
847847
if filter_deploy is True:
848848
cloudwatch.CWLOGS_CLIENT = sts.assume_role(acct, sts.CONFIGURATION_ROLE, "logs", region)
849849
cloudwatch.CLOUDWATCH_CLIENT = sts.assume_role(acct, sts.CONFIGURATION_ROLE, "cloudwatch", region)
850-
LOGGER.info(f"Filter deploy parameter is 'true'; deploying {filter} CloudWatch metric filter...")
851-
deploy_metric_filter(region, acct, filter_params["log_group_name"], filter, filter_pattern, f"{filter}-metric", "sra-bedrock", "1")
852-
LIVE_RUN_DATA[f"{filter}_CloudWatch"] = "Deployed CloudWatch metric filter"
850+
LOGGER.info(f"Filter deploy parameter is 'true'; deploying {filter_name} CloudWatch metric filter...")
851+
deploy_metric_filter(region, acct, filter_params["log_group_name"], filter_name, filter_pattern, f"{filter_name}-metric", "sra-bedrock", "1")
852+
LIVE_RUN_DATA[f"{filter_name}_CloudWatch"] = "Deployed CloudWatch metric filter"
853853
CFN_RESPONSE_DATA["deployment_info"]["action_count"] += 1
854854
CFN_RESPONSE_DATA["deployment_info"]["resources_deployed"] += 1
855855
LOGGER.info(f"DEBUG: Alarm topic ARN: {SRA_ALARM_TOPIC_ARN}")
856856
deploy_metric_alarm(
857857
region,
858858
acct,
859-
f"{filter}-alarm",
860-
f"{filter}-metric alarm",
861-
f"{filter}-metric",
859+
f"{filter_name}-alarm",
860+
f"{filter_name}-metric alarm",
861+
f"{filter_name}-metric",
862862
"sra-bedrock",
863863
"Sum",
864864
10,
@@ -868,22 +868,22 @@ def deploy_metric_filters_and_alarms(region, accounts, resource_properties):
868868
"missing",
869869
[SRA_ALARM_TOPIC_ARN],
870870
)
871-
LIVE_RUN_DATA[f"{filter}_CloudWatch_Alarm"] = "Deployed CloudWatch metric alarm"
871+
LIVE_RUN_DATA[f"{filter_name}_CloudWatch_Alarm"] = "Deployed CloudWatch metric alarm"
872872
CFN_RESPONSE_DATA["deployment_info"]["action_count"] += 1
873873
CFN_RESPONSE_DATA["deployment_info"]["resources_deployed"] += 1
874874

875875
else:
876-
LOGGER.info(f"Filter deploy parameter is 'false'; skipping {filter} CloudWatch metric filter deployment")
877-
LIVE_RUN_DATA[f"{filter}_CloudWatch"] = "Filter deploy parameter is 'false'; Skipped CloudWatch metric filter deployment"
876+
LOGGER.info(f"Filter deploy parameter is 'false'; skipping {filter_name} CloudWatch metric filter deployment")
877+
LIVE_RUN_DATA[f"{filter_name}_CloudWatch"] = "Filter deploy parameter is 'false'; Skipped CloudWatch metric filter deployment"
878878
else:
879879
if filter_deploy is True:
880-
LOGGER.info(f"DRY_RUN: Filter deploy parameter is 'true'; Deploy {filter} CloudWatch metric filter...")
881-
DRY_RUN_DATA[f"{filter}_CloudWatch"] = "DRY_RUN: Filter deploy parameter is 'true'; Deploy CloudWatch metric filter"
882-
LOGGER.info(f"DRY_RUN: Filter deploy parameter is 'true'; Deploy {filter} CloudWatch metric alarm...")
883-
DRY_RUN_DATA[f"{filter}_CloudWatch_Alarm"] = "DRY_RUN: Deploy CloudWatch metric alarm"
880+
LOGGER.info(f"DRY_RUN: Filter deploy parameter is 'true'; Deploy {filter_name} CloudWatch metric filter...")
881+
DRY_RUN_DATA[f"{filter_name}_CloudWatch"] = "DRY_RUN: Filter deploy parameter is 'true'; Deploy CloudWatch metric filter"
882+
LOGGER.info(f"DRY_RUN: Filter deploy parameter is 'true'; Deploy {filter_name} CloudWatch metric alarm...")
883+
DRY_RUN_DATA[f"{filter_name}_CloudWatch_Alarm"] = "DRY_RUN: Deploy CloudWatch metric alarm"
884884
else:
885-
LOGGER.info(f"DRY_RUN: Filter deploy parameter is 'false'; Skip {filter} CloudWatch metric filter deployment")
886-
DRY_RUN_DATA[f"{filter}_CloudWatch"] = "DRY_RUN: Filter deploy parameter is 'false'; Skip CloudWatch metric filter deployment"
885+
LOGGER.info(f"DRY_RUN: Filter deploy parameter is 'false'; Skip {filter_name} CloudWatch metric filter deployment")
886+
DRY_RUN_DATA[f"{filter_name}_CloudWatch"] = "DRY_RUN: Filter deploy parameter is 'false'; Skip CloudWatch metric filter deployment"
887887

888888
def deploy_central_cloudwatch_observability(event):
889889
global DRY_RUN_DATA

0 commit comments

Comments
 (0)