Add chrome.enable_downloads option (#221)

Author: cztomczak

src/client_handler.cpp

@@ -47,6 +47,20 @@ CefRefPtr<CefBrowser> ClientHandler::FindBrowserByXid(::Window xid) {
     return NULL;
 }
 
+void ClientHandler::OnBeforeDownload(
+        CefRefPtr<CefBrowser> browser,
+        CefRefPtr<CefDownloadItem> download_item,
+        const CefString& suggested_name,
+        CefRefPtr<CefBeforeDownloadCallback> callback) {
+    bool enable_downloads = (*get_app_settings())["chrome"]["enable_downloads"];
+    if (enable_downloads) {
+        LOG(INFO) << "About to download a file: " << suggested_name.ToString();
+        callback->Continue(suggested_name, true);
+    } else {
+        LOG(INFO) << "Tried to download a file, but downloads are disabled";
+    }
+}
+
 void ClientHandler::OnAfterCreated(CefRefPtr<CefBrowser> browser) {
     CEF_REQUIRE_UI_THREAD();
     // Add to the list of existing browsers.

src/client_handler.h

@@ -11,6 +11,7 @@
 
 class ClientHandler : public CefClient,
                       public CefDisplayHandler,
+                      public CefDownloadHandler,
                       public CefLifeSpanHandler,
                       public CefLoadHandler,
                       public CefRequestHandler
@@ -31,7 +32,10 @@ class ClientHandler : public CefClient,
     CefRefPtr<CefDisplayHandler> GetDisplayHandler() override {
         return this;
     }
-    CefRefPtr<CefJSDialogHandler> GetJSDialogHandler() {
+    CefRefPtr<CefDownloadHandler> GetDownloadHandler() override {
+        return this;
+    }
+    CefRefPtr<CefJSDialogHandler> GetJSDialogHandler() override {
         return dialog_handler_;
     }
     CefRefPtr<CefLifeSpanHandler> GetLifeSpanHandler() override {
@@ -44,6 +48,13 @@ class ClientHandler : public CefClient,
         return this;
     }
 
+    // CefDownloadHandler
+    virtual void OnBeforeDownload(
+        CefRefPtr<CefBrowser> browser,
+        CefRefPtr<CefDownloadItem> download_item,
+        const CefString& suggested_name,
+        CefRefPtr<CefBeforeDownloadCallback> callback) override;
+
     // CefLifeSpanHandler
     virtual void OnAfterCreated(CefRefPtr<CefBrowser> browser) override;
     virtual void OnBeforeClose(CefRefPtr<CefBrowser> browser) override;
@@ -52,7 +63,8 @@ class ClientHandler : public CefClient,
     virtual bool OnQuotaRequest(CefRefPtr<CefBrowser> browser,
                                 const CefString& origin_url,
                                 int64 new_size,
-                                CefRefPtr<CefRequestCallback> callback);
+                                CefRefPtr<CefRequestCallback> callback)
+                                    override;
 
 private:
     // List of existing browser windows. Only accessed on the CEF UI thread.