Skip to content

Commit d089a69

Browse files
authored
Modify lint ignores in package:web (#481)
Fixes #479 Now that we have a general purpose IDL->interop generator, we need to add ignores for constant_identifier_names and non_constant_identifier_names in every output file. unintended_html_in_doc_comment no longer applies as the original reason for it has been fixed. Removes the two lints from analysis_options.yaml as it would now be redundant. Also fixes some issues around experimental_member_use by updating the analyzer and ignoring it for redeclares.
1 parent 5a7d0be commit d089a69

File tree

200 files changed

+210
-217
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

200 files changed

+210
-217
lines changed

web/analysis_options.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ analyzer:
1616
comment_references: ignore
1717
# 14 instances in the MDN docs.
1818
lines_longer_than_80_chars: ignore
19-
# 1,333 instances in generated code.
20-
non_constant_identifier_names: ignore
21-
# 1,260 instances in generated code.
22-
constant_identifier_names: ignore
2319

2420
linter:
2521
rules:

web/lib/src/dom/accelerometer.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// Generated from Web IDL definitions.
1010

11-
// ignore_for_file: unintended_html_in_doc_comment
11+
// ignore_for_file: constant_identifier_names, non_constant_identifier_names
1212

1313
@JS()
1414
library;

web/lib/src/dom/angle_instanced_arrays.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// Generated from Web IDL definitions.
1010

11-
// ignore_for_file: unintended_html_in_doc_comment
11+
// ignore_for_file: constant_identifier_names, non_constant_identifier_names
1212

1313
@JS()
1414
library;

web/lib/src/dom/attribution_reporting_api.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// Generated from Web IDL definitions.
1010

11-
// ignore_for_file: unintended_html_in_doc_comment
11+
// ignore_for_file: constant_identifier_names, non_constant_identifier_names
1212

1313
@JS()
1414
library;

web/lib/src/dom/background_sync.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// Generated from Web IDL definitions.
1010

11-
// ignore_for_file: unintended_html_in_doc_comment
11+
// ignore_for_file: constant_identifier_names, non_constant_identifier_names
1212

1313
@JS()
1414
library;

web/lib/src/dom/battery_status.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// Generated from Web IDL definitions.
1010

11-
// ignore_for_file: unintended_html_in_doc_comment
11+
// ignore_for_file: constant_identifier_names, non_constant_identifier_names
1212

1313
@JS()
1414
library;

web/lib/src/dom/clipboard_apis.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// Generated from Web IDL definitions.
1010

11-
// ignore_for_file: unintended_html_in_doc_comment
11+
// ignore_for_file: constant_identifier_names, non_constant_identifier_names
1212

1313
@JS()
1414
library;

web/lib/src/dom/compression.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// Generated from Web IDL definitions.
1010

11-
// ignore_for_file: unintended_html_in_doc_comment
11+
// ignore_for_file: constant_identifier_names, non_constant_identifier_names
1212

1313
@JS()
1414
library;

web/lib/src/dom/console.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// Generated from Web IDL definitions.
1010

11-
// ignore_for_file: unintended_html_in_doc_comment
11+
// ignore_for_file: constant_identifier_names, non_constant_identifier_names
1212

1313
@JS()
1414
library;

web/lib/src/dom/cookie_store.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// Generated from Web IDL definitions.
1010

11-
// ignore_for_file: unintended_html_in_doc_comment
11+
// ignore_for_file: constant_identifier_names, non_constant_identifier_names
1212

1313
@JS()
1414
library;

0 commit comments

Comments
 (0)