fix(carbon): use common onChange event

Author: rvsia

packages/carbon-component-mapper/src/select/select.js

@@ -8,13 +8,7 @@ import fnToString from '@data-driven-forms/common/utils/fn-to-string';
 import { Select as CarbonSelect, MultiSelect, SelectItem, ComboBox } from 'carbon-components-react';
 import prepareProps from '../prepare-props';
 
-export const multiOnChange = (input, simpleValue) => ({ selectedItem, selectedItems }) => {
-  if (simpleValue) {
-    return input.onChange(selectedItems?.map(({ value }) => value) || selectedItem.value);
-  } else {
-    return input.onChange(selectedItems || selectedItem);
-  }
-};
+const onChangeWrapper = (onChange) => ({ selectedItem, selectedItems }) => onChange(selectedItems || selectedItem);
 
 export const getMultiValue = (value, options) =>
   (Array.isArray(value) ? value : value ? [value] : []).map((item) =>
@@ -43,7 +37,7 @@ const ClearedMultiSelectFilterable = ({
     disabled={isDisabled}
     {...rest}
     placeholder={carbonLabel || placeholder}
-    onChange={originalOnChange}
+    onChange={onChangeWrapper(onChange)}
     titleText={rest.labelText}
     id={rest.name}
     invalid={Boolean(invalidText)}
@@ -94,7 +88,7 @@ const ClearedMultiSelect = ({
     disabled={isDisabled}
     {...rest}
     label={carbonLabel || placeholder}
-    onChange={originalOnChange}
+    onChange={onChangeWrapper(onChange)}
     titleText={rest.labelText}
     id={rest.name}
     invalid={Boolean(invalidText)}
@@ -206,6 +200,7 @@ const ClearedSelectSearchable = ({
   originalOnChange,
   placeholder,
   labelText,
+  onChange,
   ...rest
 }) => (
   <ComboBox
@@ -218,7 +213,7 @@ const ClearedSelectSearchable = ({
     items={options}
     placeholder={placeholder}
     titleText={labelText}
-    onChange={originalOnChange}
+    onChange={onChangeWrapper(onChange)}
   />
 );
 
@@ -273,7 +268,6 @@ const Select = (props) => {
       loadOptions={loadOptions}
       invalidText={invalidText}
       loadOptionsChangeCounter={loadOptionsChangeCounter}
-      originalOnChange={multiOnChange(input, rest.simpleValue)}
       helperText={text}
     />
   );

packages/carbon-component-mapper/src/tests/select.test.js

@@ -6,7 +6,6 @@ import { FormRenderer, componentTypes } from '@data-driven-forms/react-form-rend
 import FormTemplate from '../form-template';
 import componentMapper from '../component-mapper';
 import { Select, MultiSelect, ComboBox } from 'carbon-components-react';
-import { multiOnChange } from '../select';
 import { getMultiValue } from '../select/select';
 
 describe('<Select />', () => {
@@ -173,28 +172,6 @@ describe('<Select />', () => {
     });
   });
 
-  describe('multichange', () => {
-    const input = {
-      onChange: jest.fn()
-    };
-
-    beforeEach(() => {
-      input.onChange.mockReset();
-    });
-
-    it('simpleValue', () => {
-      multiOnChange(input, true)({ selectedItems: [{ value: '123' }, { value: '345' }] });
-
-      expect(input.onChange).toHaveBeenCalledWith(['123', '345']);
-    });
-
-    it('not simple value', () => {
-      multiOnChange(input, false)({ selectedItems: [{ value: '123' }, { value: '345' }] });
-
-      expect(input.onChange).toHaveBeenCalledWith([{ value: '123' }, { value: '345' }]);
-    });
-  });
-
   describe('getMultiValue', () => {
     let value;
     let options;