Skip to content

Commit 98729d3

Browse files
committed
fix: fixing nx release publish
1 parent 5693c6f commit 98729d3

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

.github/workflows/main.yml

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,6 @@ jobs:
5454
run: npx nx affected --target=test --parallel=3 --coverage
5555
continue-on-error: false
5656

57-
- name: Run Nx release dry-run (PR only)
58-
if: github.event_name == 'pull_request'
59-
run: npx nx release --dry-run --verbose
60-
6157
# Job that runs ONLY after merge (on push to master)
6258
release:
6359
if: github.event_name != 'pull_request'
@@ -76,6 +72,7 @@ jobs:
7672
with:
7773
node-version: '20'
7874
cache: 'yarn'
75+
registry-url: 'https://registry.npmjs.org'
7976

8077
- name: Install dependencies
8178
run: yarn install --frozen-lockfile
@@ -90,11 +87,11 @@ jobs:
9087

9188
- name: 🚀 Run Nx Release
9289
run: |
93-
git config --global user.email "marvusm.mmi@gmail.com"
94-
git config --global user.name "Martin Marosi"
90+
echo "registry=https://registry.npmjs.org/" >> .npmrc
91+
git config --global user.email "${{ secrets.RELEASE_EMAIL }}"
92+
git config --global user.name "${{ secrets.RELEASE_USERNAME }}"
9593
96-
npx nx release --skip-publish
97-
npx nx release publish
94+
npx nx release -y
9895
env:
9996
# NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }}
10097
GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }}

nx.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@
5353
"version": {
5454
"conventionalCommits": true,
5555
"fallbackCurrentVersionResolver": "disk"
56+
},
57+
"git": {
58+
"commit": true,
59+
"commitMessage": "chore(release): publish {version} [skip ci]"
5660
}
5761
},
5862
"targetDefaults": {

0 commit comments

Comments
 (0)