Do not expect cluster in sequence steps when not found

Author: JCZuurmond

tests/integration/assessment/test_sequencing.py

@@ -1,5 +1,7 @@
 from databricks.sdk.service import jobs
 
+from databricks.labs.ucx.source_code.graph import DependencyProblem
+
 
 def test_migration_sequencing_simple_job(make_job, runtime_ctx) -> None:
     """Sequence a simple job"""
@@ -43,9 +45,15 @@ def test_migration_sequencing_job_with_task_referencing_non_existing_cluster(run
     settings = jobs.JobSettings(name="test-job", tasks=[task])
     job = jobs.Job(job_id=1234, settings=settings)
 
-    maybe_job_node = runtime_ctx.migration_sequencer.register_job(job)
-    assert maybe_job_node.failed
+    maybe_node = runtime_ctx.migration_sequencer.register_job(job)
+    assert maybe_node.failed
+    assert maybe_node.problems == [
+        DependencyProblem(
+            code="cluster-not-found",
+            message="Could not find cluster: non-existing-id",
+        )
+    ]
 
     steps = runtime_ctx.migration_sequencer.generate_steps()
     step_object_types = [step.object_type for step in steps]
-    assert step_object_types == ["CLUSTER", "TASK", "JOB"]  # TODO: What do we expect?
+    assert step_object_types == ["TASK", "JOB"]

tests/unit/assessment/test_sequencing.py

@@ -284,9 +284,8 @@ def test_sequence_steps_from_job_task_with_non_existing_cluster(ws, admin_locato
     """Sequence a job with a task that references a non-existing cluster.
 
     Sequence:
-    1. Cluster  # TODO: Do we still expect this reference?
-    2. Task
-    3. Job
+    1. Task
+    2. Job
     """
     ws.clusters.get.side_effect = ResourceDoesNotExist("Unknown cluster")
     task = jobs.Task(task_key="test-task", existing_cluster_id="non-existing-id")
@@ -298,23 +297,14 @@ def test_sequence_steps_from_job_task_with_non_existing_cluster(ws, admin_locato
     steps = list(sequencer.generate_steps())
 
     assert steps == [
-        MigrationStep(
-            step_id=2,
-            step_number=0,
-            object_type="CLUSTER",
-            object_id="non-existing-id",
-            object_name="non-existing-id",
-            object_owner="John Doe",
-            required_step_ids=[],
-        ),
         MigrationStep(
             step_id=1,
             step_number=0,
             object_type="TASK",
             object_id="1234/test-task",
             object_name="test-task",
             object_owner="John Doe",
-            required_step_ids=[2],
+            required_step_ids=[],
         ),
         MigrationStep(
             step_id=0,