fix: max_by min_by #21
Draft
+93
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Collaborator
|
what do you mean about OK and KO? |
Author
Hi, sorry for not explaining it properly last night — it was really late. By OK, I mean the expected behaviour of the test (we exclude the nulls). By KO, I mean the current incorrect behaviour: the test fails now, but without my changes it “passes” even though the result is not the expected one. The KO test should be removed before merging, since it's the opposite case and only exists to demonstrate the current incorrect behaviour. |
davidlghellin
force-pushed
the
fix/max_min_by
branch
from
9568fb5 to
a222cdc
Compare
Author
|
hi @dariocurr, I think now we can see better in 1a52b8a we can see the bug solved too in the expected values I need refactor unit test like in your code |
Author
|
sorry again, I fixed in Sail lakehq/sail#1049 and now pass the ibis test, these tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a bug
I have a test to ok and ko
In Spark
